add plastic materials #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Xiangyu-Hu @ChiZhangatTUM Please check this pull request when you are available. This is the source code for another submitted paper about soil modelling. |
Sure. |
DrChiZhang
reviewed
Aug 7, 2023
..._examples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.h
Outdated
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
..._examples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.h
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
...xamples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.hpp
Outdated
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
...xamples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.hpp
Outdated
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
...xamples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.hpp
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
...xamples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.hpp
Outdated
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
...xamples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.hpp
Outdated
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
...xamples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.hpp
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
tests/user_examples/extra_src/shared/general_continuum/riemann_solver_extra.cpp
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
tests/user_examples/extra_src/shared/general_continuum/general_continuum.h
Show resolved
Hide resolved
|
Thanks very much. I will remove these redundant variables and comments. |
DrChiZhang
reviewed
Aug 7, 2023
tests/user_examples/extra_src/shared/general_continuum/general_continuum.h
Show resolved
Hide resolved
DrChiZhang
reviewed
Aug 7, 2023
tests/user_examples/extra_src/shared/general_continuum/continuum_particles.cpp
Show resolved
Hide resolved
|
I have deleted some one-time variables and redundant comments. Please check this again when you are available. @ChiZhangatTUM |
DrChiZhang
reviewed
Aug 8, 2023
...xamples/extra_src/shared/general_continuum/continuum_dynamics/continuum_dynamics_complex.hpp
Show resolved
Hide resolved
The present version is generally OK for me. |
DrChiZhang
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plastic materials modelling with updated Lagrangian SPH.
Two benchmark cases are added for testing:
test_2d_column_collapseandtest_3d_repose_angle.