fix: potential problems for properties identification error for sensors #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekeandzeyu
changed the title
topsworld
reviewed
Jan 10, 2025
| @@ -415,12 +423,12 @@ | |||
| 'unit_of_measurement': UnitOfPower.WATT | |||
| } | |||
| }, | |||
| 'electric-current': { | |||
| 'device_class': SensorDeviceClass.CURRENT, | |||
| 'over-electric-power': { | |||
There was a problem hiding this comment.
over-electric-power is a invalid SPEC prop
There was a problem hiding this comment.
I'm sorry but maybe I didn't notice before, how can I know if something is a valid SPEC prop? In the issue #589 it has "过功率" as a property, and I have no idea what's its SPEC prop is.
There was a problem hiding this comment.
The SPEC is defined as follows: http://miot-spec.srv/miot-spec-v2/instance?type=urn:miot-spec-v2:device:outlet:0000A002:chuangmi-212a01:3
{
"iid": 5,
"type": "urn:miot-spec-v2:service:power-consumption:0000780E:chuangmi-212a01:1",
"description": "Power Consumption",
"properties": [
{
"iid": 1,
"type": "urn:miot-spec-v2:property:power-consumption:0000002F:chuangmi-212a01:1",
"description": "Power Consumption",
"format": "uint32",
"access": [
"read",
"notify"
],
"unit": "none",
"value-range": [
0,
65535000,
1
]
},
{
"iid": 2,
"type": "urn:miot-spec-v2:property:electric-current:00000030:chuangmi-212a01:1",
"description": "Electric Current",
"format": "uint16",
"access": [
"read",
"notify"
],
"value-range": [
0,
65535,
1
]
},
{
"iid": 3,
"type": "urn:miot-spec-v2:property:voltage:00000031:chuangmi-212a01:1",
"description": "Voltage",
"format": "uint16",
"access": [
"read",
"notify"
],
"value-range": [
0,
65535,
1
]
},
{
"iid": 6,
"type": "urn:miot-spec-v2:property:electric-power:00000066:chuangmi-212a01:1",
"description": "Electric Power",
"format": "uint32",
"access": [
"read",
"notify"
],
"unit": "watt",
"value-range": [
0,
6553500,
1
],
"gatt-access": []
},
{
"iid": 7,
"type": "urn:miot-spec-v2:property:surge-power:00000033:chuangmi-212a01:2",
"description": "Surge power",
"format": "uint32",
"access": [
"read",
"notify"
],
"value-range": [
0,
65525,
1
]
}
]
}There was a problem hiding this comment.
Thanks! Although I cannot open the link, I changed the corresponding SPEC name from the code you provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
To fix #589
Why?
The SPEC_PROP_TRANS_MAP in specs/specv2entity.py seem to have potential problems for electrical current, power assumption and over load power assumption (OPP). For features like OPP, there seems to have no clear definitions in Home Assistant Sensor properties. For others, I believe the mapping can be the source of idenfication errors.