Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move web page to html #627

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Conversation

chemwolf6922
Copy link
Contributor

@chemwolf6922 chemwolf6922 commented Jan 11, 2025

Why is this change made

Putting the webpage inside a string is not ideal for maintenance.

Changes

  • Move the web page to a html file.
  • Translate using miot i18n.

Tests

Tested login in my local environment.

@topsworld topsworld changed the title Move web page to html feat: move web page to html Jan 13, 2025
@topsworld topsworld added the enhancement New feature or request label Jan 13, 2025
@topsworld topsworld requested a review from SusanPhevos January 13, 2025 09:38
@topsworld topsworld requested a review from JimmyKmi January 13, 2025 14:20
Copy link
Contributor

@topsworld topsworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed in my develop machine.

@topsworld topsworld merged commit 2881948 into XiaoMi:main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants