Fix root makefile to work with linux 6.10 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux 6.10 has broken Onload kernel modules build by replacing $(src) with $(obj) in its makefiles. See Linux commit 9a0ebe5011f49e932bb0a2cea2034fd65e6e567e This patch implements a possible approach - create symlinks to Onload source files in build directory. Signed-off-by: Sergey Nikitin <sergey.nikitin@oktet.tech>
ol-alexandra
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
I'd like to see a comment from @rhughes-xilinx who created the driver build system which Onload is using now.
|
One of my goals for this build system was not to have to do this kind of copying/linking (one reason being that it causes difficulties with deleted files), so it's disappointing to see it come back. I shouldn't be spending time on coming up with another intricate trick which avoids it, however. If somebody else has given it a good try and failed then I'll accept that conclusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux 6.10 has broken Onload kernel modules build by replacing$(src) with $ (obj) in its makefiles.
See Linux commit 9a0ebe5011f49e932bb0a2cea2034fd65e6e567e
This patch implements a possible approach - create symlinks to Onload source files in build directory.
Possible fix for #236
Checked on CentOS 9
6.10.5-1.el9.elrepo.x86_64and Ubuntu 22.046.8.0-40-genericby runningmake/mmakebuildtree --driver && make.Note: there are other build issues, related to linux-6.10, which I'll address separately.