Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19_3] port one-param as_hexadecimal to lolly #332

Merged
merged 2 commits into from
Jun 7, 2024
Merged

[19_3] port one-param as_hexadecimal to lolly #332

merged 2 commits into from
Jun 7, 2024

Conversation

jingkaimori
Copy link
Contributor

@jingkaimori jingkaimori commented Jun 7, 2024 •
edited
Loading

see also #242

@jingkaimori jingkaimori requested a review from da-liii June 7, 2024 05:46
da-liii
da-liii reviewed Jun 7, 2024
View reviewed changes
lolly/data/numeral.cpp Outdated Show resolved Hide resolved
@da-liii da-liii changed the title port one-param as_hexadecimal to lolly [19_3] port one-param as_hexadecimal to lolly Jun 7, 2024
da-liii
da-liii approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii da-liii merged commit bb20429 into main Jun 7, 2024
12 checks passed
@da-liii da-liii deleted the jingkaimori/numeral-port branch June 7, 2024 09:32
@da-liii
Copy link
Contributor

da-liii commented Jun 18, 2024

I thought as_hexadecimal is an existing interface in Mogan, but I found that there are no usage of as_hexadecimal(uint32)

@da-liii
Copy link
Contributor

da-liii commented Jun 18, 2024

I mean the original as_hexadecimal receives int32 as input, and your are changing the semantics of as_hexadecimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da-liii da-liii da-liii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jingkaimori @da-liii