Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15_8] Deprecate the json support #339

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[15_8] Deprecate the json support #339

merged 2 commits into from
Jul 12, 2024

Conversation

da-liii
Copy link
Contributor

@da-liii da-liii commented Jul 12, 2024

No description provided.

@da-liii da-liii requested review from jingkaimori and Oyyko July 12, 2024 05:34
Oyyko
Oyyko approved these changes Jul 12, 2024
View reviewed changes
Copy link

@Oyyko Oyyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jingkaimori
jingkaimori approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@jingkaimori jingkaimori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingkaimori
Copy link
Contributor

lolly/lolly/data/unicode.cpp

Lines 3 to 4 in 379a0b0

* MODULE : json.cpp
* DESCRIPTION: Json Data Type
json comment here should be changed.

@da-liii
Copy link
Contributor Author

da-liii commented Jul 12, 2024

json comment here should be changed.

Will fix it in another pr

@da-liii da-liii merged commit 098c547 into main Jul 12, 2024
12 checks passed
@da-liii da-liii deleted the da/15_8/remove_json branch July 12, 2024 10:48
@da-liii
Copy link
Contributor Author

da-liii commented Jul 12, 2024

Will fix it in another pr

b4fa20c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oyyko Oyyko Oyyko approved these changes

@jingkaimori jingkaimori jingkaimori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@da-liii @jingkaimori @Oyyko