Unqualified function/constant reference

XoopsModules25x · Oct 29, 2021 · efdf48c · efdf48c
1 parent fde3154
commit efdf48c
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 16 deletions.
diff --git a/class/Common/Breadcrumb.php b/class/Common/Breadcrumb.php
@@ -41,7 +41,7 @@ class Breadcrumb
 
     public function __construct()
     {
-        $this->dirname = \basename(dirname(__DIR__, 2));
+        $this->dirname = \basename(\dirname(__DIR__, 2));
     }
 
     /**

diff --git a/class/Common/FineimpuploadHandler.php b/class/Common/FineimpuploadHandler.php
@@ -119,7 +119,7 @@ public function __construct(\stdClass $claims)
      */
     protected function storeUploadedFile($target, $mimeType, $uid)
     {
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
         require_once XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/header.php';
         $this->pathUpload = \constant($moduleDirNameUpper . '_' . 'UPLOAD_IMAGE_PATH');
@@ -205,7 +205,7 @@ protected function storeUploadedFile($target, $mimeType, $uid)
      */
     private function handleImageDB()
     {
-        $moduleDirName = \basename(dirname(__DIR__, 2));
+        $moduleDirName = \basename(\dirname(__DIR__, 2));
         require_once XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/header.php';
         global $xoopsUser;
         $this->getImageDim();

diff --git a/class/Common/Images.php b/class/Common/Images.php
@@ -87,7 +87,7 @@ public function getNewInsertedIdImages()
      */
     public function getFormImages($action = false)
     {
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
         $helper             = Helper::getInstance();
         if (!$action) {
@@ -175,7 +175,7 @@ public function getFormImages($action = false)
      */
     public function getValuesImages($keys = null, $format = null, $maxDepth = null)
     {
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
         $helper             = Helper::getInstance();
         $ret                = $this->getValues($keys, $format, $maxDepth);

diff --git a/class/Common/Migrate.php b/class/Common/Migrate.php
@@ -41,7 +41,7 @@ public function __construct()
         }
         $configurator       = new $class();
         $this->renameTables = $configurator->renameTables;
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         parent::__construct($moduleDirName);
     }
 

diff --git a/class/Common/ServerStats.php b/class/Common/ServerStats.php
@@ -29,7 +29,7 @@ trait ServerStats
     public static function getServerStats()
     {
         //mb    $wfdownloads = WfdownloadsWfdownloads::getInstance();
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
         \xoops_loadLanguage('common', $moduleDirName);
         $html = '';

diff --git a/class/Common/SysUtility.php b/class/Common/SysUtility.php
@@ -177,15 +177,15 @@ public static function cloneRecord(string $tableName, string $idField, int $id)
         $sql       = "SELECT * FROM $table WHERE $idField='" . $id . "' ";
         $tempTable = $GLOBALS['xoopsDB']->fetchArray($GLOBALS['xoopsDB']->query($sql), \MYSQLI_ASSOC);
         if (!$tempTable) {
-            trigger_error($GLOBALS['xoopsDB']->error());
+            \trigger_error($GLOBALS['xoopsDB']->error());
         }
         // set the auto-incremented id's value to blank.
         unset($tempTable[$idField]);
         // insert cloned copy of the original  record
         $sql    = "INSERT INTO $table (" . \implode(', ', \array_keys($tempTable)) . ") VALUES ('" . \implode("', '", \array_values($tempTable)) . "')";
         $result = $GLOBALS['xoopsDB']->queryF($sql);
         if (!$result) {
-            trigger_error($GLOBALS['xoopsDB']->error());
+            \trigger_error($GLOBALS['xoopsDB']->error());
         }
         // Return the new id
         return $GLOBALS['xoopsDB']->getInsertId();

diff --git a/class/Common/VersionChecks.php b/class/Common/VersionChecks.php
@@ -31,7 +31,7 @@ trait VersionChecks
      */
     public static function checkVerXoops(?\XoopsModule $module = null, $requiredVer = null)
     {
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
         if (null === $module) {
             $module = \XoopsModule::getByDirname($moduleDirName);
@@ -59,7 +59,7 @@ public static function checkVerXoops(?\XoopsModule $module = null, $requiredVer
      */
     public static function checkVerPhp(?\XoopsModule $module = null)
     {
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
         if (null === $module) {
             $module = \XoopsModule::getByDirname($moduleDirName);
@@ -90,7 +90,7 @@ public static function checkVerPhp(?\XoopsModule $module = null)
      */
     public static function checkVerModule(\Xmf\Module\Helper $helper, ?string $source = 'github', ?string $default = 'master'): ?array
     {
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
         $update             = '';
         $repository         = 'XoopsModules25x/' . $moduleDirName;

diff --git a/class/Form/UploadForm.php b/class/Form/UploadForm.php
@@ -29,7 +29,7 @@
 use Xmf\Request;
 use XoopsModules\Tdmdownloads;
 
-require_once dirname(__DIR__, 2) . '/include/common.php';
+require_once \dirname(__DIR__, 2) . '/include/common.php';
 //$moduleDirName = basename(dirname(dirname(__DIR__)));
 //$helper = Tdmdownloads\Helper::getInstance();
 $permHelper = new \Xmf\Module\Helper\Permission();
@@ -50,7 +50,7 @@ class UploadForm extends \XoopsThemeForm
      */
     public function __construct($target)
     {
-        $moduleDirName      = \basename(dirname(__DIR__, 2));
+        $moduleDirName      = \basename(\dirname(__DIR__, 2));
         $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
         /** @var \XoopsModules\Tdmdownloads\Helper $this- >helper */
         $this->helper       = $target->helper;

diff --git a/class/Utility.php b/class/Utility.php
@@ -82,7 +82,7 @@ public function getNumbersOfEntries($mytree, $categories, $entries, $cid)
     public function getStatusImage($time, $status)
     {
         global $xoopsModuleConfig;
-        $moduleDirName = basename(dirname(__DIR__));
+        $moduleDirName = \basename(\dirname(__DIR__));
         $helper        = Helper::getInstance();
         $count         = 7;
         $new           = '';
@@ -121,7 +121,7 @@ public function getStatusImage($time, $status)
     public function getPopularImage($hits)
     {
         global $xoopsModuleConfig;
-        $moduleDirName = basename(dirname(__DIR__));
+        $moduleDirName = \basename(\dirname(__DIR__));
         $pop           = '';
         if ($hits >= $xoopsModuleConfig['popular']) {
             $language = $GLOBALS['xoopsConfig']['language'];