Skip to content

Commit

Permalink
Merge pull request #150 from YAPP-Github/develop
Browse files Browse the repository at this point in the history
Release 0.2.9
  • Loading branch information
le2sky authored Jun 1, 2023
2 parents 3da6db6 + de64beb commit f87f697
Show file tree
Hide file tree
Showing 42 changed files with 65 additions and 80 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,10 @@ public Category findCategoryWithUser(Long id, Long userId) {
}

public List<CategoryDto> categoriesOf(Long userId) {
UserJpaEntity user = findUser(userId);
List<CategoryDto> categories = categoryRepository.findCategoriesByUserOrderBySequence(user)
.stream().map(this::buildCategoryDto).collect(
Collectors.toList());
validateExistAtLeastOneCategory(categories);

return categories;
return categoryRepository.findCategoriesByUserOrderBySequence(findUser(userId))
.stream()
.map(this::buildCategoryDto)
.collect(Collectors.toList());
}

@Transactional
Expand Down Expand Up @@ -110,12 +107,6 @@ private int getSequence(UserJpaEntity user) {
return categoryRepository.countCategoriesByUser(user);
}

private void validateExistAtLeastOneCategory(List<CategoryDto> categories) {
if (categories.size() == 0) {
throw new CategoryNotFoundException();
}
}

private void validateDuplicateCategory(String name, UserJpaEntity user) {
List<CategoryDto> categories = categoryRepository.findCategoryDto(user);
long count = categories.stream()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.yapp.artie.domain.user.adapter.in.web;

import com.yapp.artie.domain.user.application.port.in.GetTestUserTokenQuery;
import com.yapp.artie.domain.user.application.port.in.GetTestUserTokenResponse;
import com.yapp.artie.domain.user.application.port.in.query.GetTestUserTokenQuery;
import com.yapp.artie.domain.user.application.port.in.response.GetTestUserTokenResponse;
import com.yapp.artie.global.common.annotation.WebAdapter;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.yapp.artie.domain.user.adapter.in.web;

import com.yapp.artie.domain.user.application.port.in.GetUserQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetUserQuery;
import com.yapp.artie.domain.user.domain.User;
import com.yapp.artie.global.common.annotation.WebAdapter;
import io.swagger.v3.oas.annotations.Operation;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.yapp.artie.domain.user.adapter.in.web;

import com.yapp.artie.domain.user.application.port.in.GetUserJoinDateQuery;
import com.yapp.artie.domain.user.application.port.in.GetUserJoinDateResponse;
import com.yapp.artie.domain.user.application.port.in.query.GetUserJoinDateQuery;
import com.yapp.artie.domain.user.application.port.in.response.GetUserJoinDateResponse;
import com.yapp.artie.global.common.annotation.WebAdapter;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.yapp.artie.domain.user.adapter.in.web;

import com.yapp.artie.domain.user.adapter.out.persistence.UserJpaEntity;
import com.yapp.artie.domain.user.application.port.in.GetUserThumbnailQuery;
import com.yapp.artie.domain.user.application.port.in.GetUserThumbnailResponse;
import com.yapp.artie.domain.user.application.port.in.query.GetUserThumbnailQuery;
import com.yapp.artie.domain.user.application.port.in.response.GetUserThumbnailResponse;
import com.yapp.artie.global.common.annotation.WebAdapter;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.media.Content;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.yapp.artie.domain.user.adapter.in.web;


import com.yapp.artie.domain.user.application.port.in.RegisterUserResponse;
import com.yapp.artie.domain.user.application.port.in.RegisterUserUseCase;
import com.yapp.artie.domain.user.application.port.in.command.RegisterUserUseCase;
import com.yapp.artie.domain.user.application.port.in.response.RegisterUserResponse;
import com.yapp.artie.domain.user.application.port.out.TokenParsingPort;
import com.yapp.artie.domain.user.domain.ArtieToken;
import com.yapp.artie.global.common.annotation.WebAdapter;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.yapp.artie.domain.user.adapter.in.web;

import com.yapp.artie.domain.user.application.port.in.RenameUserUseCase;
import com.yapp.artie.domain.user.application.port.in.command.RenameUserUseCase;
import com.yapp.artie.global.common.annotation.WebAdapter;
import com.yapp.artie.global.common.exception.ErrorResponse;
import io.swagger.v3.oas.annotations.Operation;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.yapp.artie.domain.user.adapter.in.web;

import com.yapp.artie.domain.user.application.port.in.UserWithdrawalUseCase;
import com.yapp.artie.domain.user.application.port.in.command.UserWithdrawalUseCase;
import com.yapp.artie.global.common.annotation.WebAdapter;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.media.Content;
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package com.yapp.artie.domain.user.application.port.in.command;

import com.yapp.artie.domain.user.application.port.in.response.RegisterUserResponse;

public interface RegisterUserUseCase {

RegisterUserResponse register(String uid, String username, String picture);
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.command;

public interface RenameUserUseCase {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.command;

public interface UserWithdrawalUseCase {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.query;

public interface GetTestUserTokenQuery {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.query;

import org.springframework.security.core.userdetails.UserDetails;
import org.springframework.security.core.userdetails.UserDetailsService;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.query;

import java.time.LocalDateTime;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.query;

import com.yapp.artie.domain.user.domain.User;

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package com.yapp.artie.domain.user.application.port.in.query;

import com.yapp.artie.domain.user.application.port.in.response.GetUserThumbnailResponse;

public interface GetUserThumbnailQuery {

GetUserThumbnailResponse loadUserThumbnailById(Long id);
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.response;

import io.swagger.v3.oas.annotations.media.Schema;
import lombok.Getter;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.response;

import io.swagger.v3.oas.annotations.media.Schema;
import java.time.LocalDateTime;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.response;

import io.swagger.v3.oas.annotations.media.Schema;
import lombok.AccessLevel;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.yapp.artie.domain.user.application.port.in;
package com.yapp.artie.domain.user.application.port.in.response;

import io.swagger.v3.oas.annotations.media.Schema;
import lombok.Getter;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.yapp.artie.domain.user.application.service;

import com.yapp.artie.domain.user.application.port.in.GetTestUserTokenQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetTestUserTokenQuery;
import com.yapp.artie.domain.user.application.port.out.GenerateTestTokenPort;
import com.yapp.artie.domain.user.application.port.out.LoadUserPort;
import com.yapp.artie.global.common.annotation.UseCase;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import static org.springframework.security.core.userdetails.User.builder;

import com.yapp.artie.domain.user.application.port.in.GetUserDetailsQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetUserDetailsQuery;
import com.yapp.artie.domain.user.application.port.out.LoadUserPort;
import com.yapp.artie.domain.user.domain.User;
import com.yapp.artie.global.common.annotation.UseCase;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.yapp.artie.domain.user.application.service;

import com.yapp.artie.domain.user.application.port.in.GetUserJoinDateQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetUserJoinDateQuery;
import com.yapp.artie.domain.user.application.port.out.LoadUserPort;
import com.yapp.artie.global.common.annotation.UseCase;
import java.time.LocalDateTime;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.yapp.artie.domain.user.application.service;

import com.yapp.artie.domain.user.application.port.in.GetUserQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetUserQuery;
import com.yapp.artie.domain.user.application.port.out.LoadUserPort;
import com.yapp.artie.domain.user.domain.User;
import com.yapp.artie.global.common.annotation.UseCase;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@


import com.yapp.artie.domain.archive.service.ExhibitService;
import com.yapp.artie.domain.user.application.port.in.GetUserThumbnailQuery;
import com.yapp.artie.domain.user.application.port.in.GetUserThumbnailResponse;
import com.yapp.artie.domain.user.application.port.in.query.GetUserThumbnailQuery;
import com.yapp.artie.domain.user.application.port.in.response.GetUserThumbnailResponse;
import com.yapp.artie.domain.user.application.port.out.LoadUserPort;
import com.yapp.artie.domain.user.domain.User;
import com.yapp.artie.global.common.annotation.UseCase;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.yapp.artie.domain.user.application.service;

import com.yapp.artie.domain.user.application.port.in.RegisterUserResponse;
import com.yapp.artie.domain.user.application.port.in.RegisterUserUseCase;
import com.yapp.artie.domain.user.application.port.in.command.RegisterUserUseCase;
import com.yapp.artie.domain.user.application.port.in.response.RegisterUserResponse;
import com.yapp.artie.domain.user.application.port.out.LoadUserPort;
import com.yapp.artie.domain.user.application.port.out.SaveUserPort;
import com.yapp.artie.domain.user.domain.User;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.yapp.artie.domain.user.application.service;

import com.yapp.artie.domain.user.application.port.in.RenameUserUseCase;
import com.yapp.artie.domain.user.application.port.in.command.RenameUserUseCase;
import com.yapp.artie.domain.user.application.port.out.LoadUserPort;
import com.yapp.artie.domain.user.application.port.out.UpdateUserStatePort;
import com.yapp.artie.domain.user.domain.User;
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import com.yapp.artie.domain.archive.repository.CategoryRepository;
import com.yapp.artie.domain.user.adapter.out.persistence.UserJpaEntity;
import com.yapp.artie.domain.user.application.port.in.UserWithdrawalUseCase;
import com.yapp.artie.domain.user.application.port.in.command.UserWithdrawalUseCase;
import com.yapp.artie.domain.user.application.port.out.DeleteExternalUserPort;
import com.yapp.artie.domain.user.application.port.out.DeleteUserPort;
import com.yapp.artie.domain.user.application.port.out.LoadUserPort;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ public void configure(HttpSecurity http) throws Exception {

http.exceptionHandling()
.authenticationEntryPoint(new HttpStatusEntryPoint(HttpStatus.UNAUTHORIZED));

http.cors();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,9 @@ private Category findCategory(Long id) {
}

@Test
public void categoriesOf_카테고리가_하나도_존재하지_않으면_예외를_발생한다() throws Exception {
assertThatThrownBy(() -> {
categoryService.categoriesOf(findUser("1").getId());
}).isInstanceOf(CategoryNotFoundException.class);
public void categoriesOf_카테고리가_하나도_존재하지_않는다면__리스트를_반환한다() throws Exception {
List<CategoryDto> actual = categoryService.categoriesOf(findUser("1").getId());
assertThat(actual.size()).isEqualTo(0);
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import com.yapp.artie.common.BaseControllerIntegrationTest;
import com.yapp.artie.domain.user.application.port.in.GetTestUserTokenQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetTestUserTokenQuery;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import com.yapp.artie.common.BaseControllerIntegrationTest;
import com.yapp.artie.domain.user.application.port.in.GetUserQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetUserQuery;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import com.yapp.artie.common.BaseControllerIntegrationTest;
import com.yapp.artie.domain.user.application.port.in.GetUserJoinDateQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetUserJoinDateQuery;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import com.yapp.artie.common.BaseControllerIntegrationTest;
import com.yapp.artie.domain.user.application.port.in.GetUserThumbnailQuery;
import com.yapp.artie.domain.user.application.port.in.query.GetUserThumbnailQuery;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import com.yapp.artie.common.BaseControllerIntegrationTest;
import com.yapp.artie.domain.user.application.port.in.RegisterUserUseCase;
import com.yapp.artie.domain.user.application.port.in.command.RegisterUserUseCase;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import com.yapp.artie.common.BaseControllerIntegrationTest;
import com.yapp.artie.domain.user.application.port.in.RenameUserUseCase;
import com.yapp.artie.domain.user.application.port.in.command.RenameUserUseCase;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import com.yapp.artie.common.BaseControllerIntegrationTest;
import com.yapp.artie.domain.user.application.port.in.UserWithdrawalUseCase;
import com.yapp.artie.domain.user.application.port.in.command.UserWithdrawalUseCase;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import com.yapp.artie.common.BaseUserUnitTest;
import com.yapp.artie.domain.archive.service.ExhibitService;
import com.yapp.artie.domain.user.application.port.in.GetUserThumbnailResponse;
import com.yapp.artie.domain.user.application.port.in.response.GetUserThumbnailResponse;
import com.yapp.artie.domain.user.domain.User;
import com.yapp.artie.domain.user.domain.UserNotFoundException;
import org.junit.jupiter.api.Test;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import static org.mockito.Mockito.never;

import com.yapp.artie.common.BaseUserUnitTest;
import com.yapp.artie.domain.user.application.port.in.RegisterUserResponse;
import com.yapp.artie.domain.user.application.port.in.response.RegisterUserResponse;
import org.junit.jupiter.api.Test;

class RegisterUserServiceTest extends BaseUserUnitTest {
Expand Down

0 comments on commit f87f697

Please sign in to comment.