change self modifier to reduce clone()

Yamato-Security · Feb 1, 2024 · 62028b6 · 62028b6
1 parent 812c56b
commit 62028b6
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/src/detections/rule/condition_parser.rs b/src/detections/rule/condition_parser.rs
@@ -58,7 +58,7 @@ impl IntoIterator for ConditionToken {
 }
 
 impl ConditionToken {
-    fn replace_subtoken(&self, sub_tokens: Vec<ConditionToken>) -> ConditionToken {
+    fn replace_subtoken(self, sub_tokens: Vec<ConditionToken>) -> ConditionToken {
         match self {
             ConditionToken::ParenthesisContainer(_) => {
                 ConditionToken::ParenthesisContainer(sub_tokens.into_iter())
@@ -69,15 +69,13 @@ impl ConditionToken {
             ConditionToken::OperandContainer(_) => {
                 ConditionToken::OperandContainer(sub_tokens.into_iter())
             }
-            ConditionToken::LeftParenthesis => ConditionToken::LeftParenthesis,
-            ConditionToken::RightParenthesis => ConditionToken::RightParenthesis,
-            ConditionToken::Space => ConditionToken::Space,
-            ConditionToken::Not => ConditionToken::Not,
-            ConditionToken::And => ConditionToken::And,
-            ConditionToken::Or => ConditionToken::Or,
-            ConditionToken::SelectionReference(name) => {
-                ConditionToken::SelectionReference(name.clone())
-            }
+            ConditionToken::LeftParenthesis => self,
+            ConditionToken::RightParenthesis => self,
+            ConditionToken::Space => self,
+            ConditionToken::Not => self,
+            ConditionToken::And => self,
+            ConditionToken::Or => self,
+            ConditionToken::SelectionReference(_) => self,
         }
     }