-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --include-tag
and --exclude-tag
options in pivot-keywords-list
command
#1196
Conversation
--include-tag
and --exclude-tag
options in pivot-keywords-list
command
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 1188-ask-the-user-which-sigma-rules-they-want-to-enable-by-default-1 #1196 +/- ##
========================================================================================================
- Coverage 83.52% 83.50% -0.02%
========================================================================================================
Files 26 26
Lines 23608 23696 +88
========================================================================================================
+ Hits 19718 19788 +70
- Misses 3890 3908 +18
☔ View full report in Codecov by Sentry. |
@hitenkoku When I run |
…-by-default-1' into add-include-and-exclude-tag-in-pivot-keywords-list#1195
@YamatoSecurity Thanks for your review. I fixed following bug in c940b46. Could you check it?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku Thanks for fixing this. LGTM!
@YamatoSecurity I appriciate your continuous review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed following command works! LGTM!!🚀
% ./hayabusa-new pivot-keywords-list -d ../hayabusa-sample-evtx -o ./new/key -C --debug --exclude-tag sysmon -w -v
% ./hayabusa-new pivot-keywords-list -d ../hayabusa-sample-evtx -o ./new/key -C --debug --include-tag sysmon -w -v
Also, the following command results have no difference compared to main.
% ./hayabusa-new csv-timeline -d ../hayabusa-sample-evtx -o new.csv -C -w
% ./hayabusa-new pivot-keywords-list -d ../hayabusa-sample-evtx -o ./old/key -C -w
@fukusuket thanks for your review. |
a2971d3
into
1188-ask-the-user-which-sigma-rules-they-want-to-enable-by-default-1
What Changed
--include-tag
option topivot-keywords-list
command to only load rules with the specifiedtags
field.--exclude-tag
option topivot-keywords-list
commands to exclude rules with specifictags
from being loaded.I would appreciate it if you could review when you have time.