Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set include_status * when update-rules command. #1210

Merged
merged 4 commits into from
Nov 5, 2023

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Nov 4, 2023

What Changed

Evidence

Enviroment

  • OS: macOS Sonoma version 14.0

The updated rule name will be displayed as shown below.

fukusuke@fukusukenoAir hayabusa-2.10.0-all-platforms % ./hayabusa update-rules

╔╗ ╔╦═══╦╗  ╔╦═══╦══╗╔╗ ╔╦═══╦═══╗
║║ ║║╔═╗║╚╗╔╝║╔═╗║╔╗║║║ ║║╔═╗║╔═╗║
║╚═╝║║ ║╠╗╚╝╔╣║ ║║╚╝╚╣║ ║║╚══╣║ ║║
║╔═╗║╚═╝║╚╗╔╝║╚═╝║╔═╗║║ ║╠══╗║╚═╝║
║║ ║║╔═╗║ ║║ ║╔═╗║╚═╝║╚═╝║╚═╝║╔═╗║
╚╝ ╚╩╝ ╚╝ ╚╝ ╚╝ ╚╩═══╩═══╩═══╩╝ ╚╝
   by Yamato Security

Start time: 2023/11/04 23:15

 - Uncommon PowerShell Hosts (Modified: 2023/11/03 | Path: rules/sigma/builtin/powershell/powershell_classic/posh_pc_alternate_powershell_hosts.yml)
 - Suspicious Non-Browser Network Communication With Google API (Modified: 2023/11/03 | Path: rules/sigma/sysmon/network_connection/net_connection_win_google_api_non_browser_access.yml)

Updated Sigma rules: 2
Rules updated successfully.

I would appreciate it if you could review when you have time🙏

@fukusuket fukusuket self-assigned this Nov 4, 2023
@fukusuket fukusuket added the bug Something isn't working label Nov 4, 2023
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e7ead3a) 83.60% compared to head (480b069) 83.60%.

❗ Current head 480b069 differs from pull request most recent head 408ec73. Consider uploading reports for the commit 408ec73 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1210   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files          26       26           
  Lines       23818    23818           
=======================================
  Hits        19912    19912           
  Misses       3906     3906           
Files Coverage Δ
src/main.rs 65.75% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fukusuket fukusuket marked this pull request as ready for review November 4, 2023 14:52
Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket Thanks for your pull request.
LGTM

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YamatoSecurity YamatoSecurity merged commit 7006a2d into main Nov 5, 2023
7 checks passed
@fukusuket fukusuket deleted the 1209-fix-update-rules-msg branch November 27, 2023 10:36
@hitenkoku hitenkoku added this to the v2.10.1 milestone Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] update-rules command always output You currently have the latest rules.
3 participants