Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stricter checks for options #1233

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

YamatoSecurity
Copy link
Collaborator

closes #1232

I made the required options a little stricter and updated csv to 1.3 as it is just a minor update.
Please check when you have time.

@YamatoSecurity YamatoSecurity added this to the v2.12.0 milestone Dec 18, 2023
@YamatoSecurity YamatoSecurity self-assigned this Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8442c1) 82.56% compared to head (d7a1ea9) 82.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files          27       27           
  Lines       24678    24678           
=======================================
  Hits        20376    20376           
  Misses       4302     4302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request.
LGTM

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀

@YamatoSecurity YamatoSecurity merged commit fa8e518 into main Dec 18, 2023
9 checks passed
@YamatoSecurity YamatoSecurity deleted the 1232-stricter-required-options branch March 1, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stricter required options
3 participants