-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Details
output in json-timeline
output to original rule order
#1265
Changed Details
output in json-timeline
output to original rule order
#1265
Conversation
…r to original order in rule #1264
Details
output in json-timeline
output to original rule order
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
=======================================
Coverage 82.17% 82.18%
=======================================
Files 27 27
Lines 24260 24269 +9
=======================================
+ Hits 19936 19945 +9
Misses 4324 4324 ☔ View full report in Codecov by Sentry. |
Evidence
Please check #1264 description.
I used rule in #1264 description (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that both csv-timeline/json-timeline work :) LGTM!!🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku LGTM! Thank you!
What Changed
Details
output injson-timeline
command from alphabetical order to the original order.I would appreciate it if you could review when you have time.