-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipped loading detection rules when running search
, logon-summary
, eid-metrics
, and computer-metrics
#1267
Skipped loading detection rules when running search
, logon-summary
, eid-metrics
, and computer-metrics
#1267
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
- Coverage 82.18% 82.12% -0.07%
==========================================
Files 27 27
Lines 24313 24332 +19
==========================================
+ Hits 19981 19982 +1
- Misses 4332 4350 +18 ☔ View full report in Codecov by Sentry. |
Evidence
|
…hich is no need to load rule #1263
6e61ee5
to
57c9509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed the following points. :) LGTM!!🚀
not rule loaded
- computer-metrics
- eid-metrics
- logon-summary
- search
rule loaded
- csv-timeline
- json-timeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku LGTM! Thanks so much! @fukusuket Thank you for checking the other commands as well!
What Changed
search
,logon-summary
,eid-metrics
, andcomputer-metrics
I would appreciate it if you could review when you have time.