Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped loading detection rules when running search, logon-summary, eid-metrics, and computer-metrics #1267

Merged

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • Skipped loading detection rules when running search, logon-summary, eid-metrics, and computer-metrics

I would appreciate it if you could review when you have time.

@hitenkoku hitenkoku added the enhancement New feature or request label Feb 3, 2024
@hitenkoku hitenkoku self-assigned this Feb 3, 2024
@hitenkoku hitenkoku linked an issue Feb 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e052fc5) 82.18% compared to head (57c9509) 82.12%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/main.rs 86.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1267      +/-   ##
==========================================
- Coverage   82.18%   82.12%   -0.07%     
==========================================
  Files          27       27              
  Lines       24313    24332      +19     
==========================================
+ Hits        19981    19982       +1     
- Misses       4332     4350      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hitenkoku
Copy link
Collaborator Author

Evidence

> ./1263.exe  search -r ".*" -d ../hayabusa-sample-evtx -F EventID:6009
...
Searching...

Start time: 2024/02/03 23:17

Total event log files: 581
Total file size: 136.9 MB

Currently searching. Please wait.

@hitenkoku hitenkoku force-pushed the 1263-skip-loading-detection-rules-when-running-search branch from 6e61ee5 to 57c9509 Compare February 3, 2024 14:21
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the following points. :) LGTM!!🚀

not rule loaded

  • computer-metrics
  • eid-metrics
  • logon-summary
  • search

rule loaded

  • csv-timeline
  • json-timeline

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku LGTM! Thanks so much! @fukusuket Thank you for checking the other commands as well!

@YamatoSecurity YamatoSecurity merged commit 8c2a859 into main Feb 3, 2024
9 checks passed
@hitenkoku hitenkoku deleted the 1263-skip-loading-detection-rules-when-running-search branch February 3, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip loading detection rules when running search
3 participants