-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed progress bar and wizard colored output when --no-color
option is used
#1269
Fixed progress bar and wizard colored output when --no-color
option is used
#1269
Conversation
Evidence
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
- Coverage 82.18% 82.09% -0.09%
==========================================
Files 27 27
Lines 24313 24337 +24
==========================================
- Hits 19981 19980 -1
- Misses 4332 4357 +25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku
I confirmed following command with --no-color :)
- csv-timeline
- json-timeline
- eid-metrics
- computer-metrics
- pivot-keywords-list
- logon-summary
It seems that only the search command is still colored. Could you please confirm?
@fukusuket Thanks for your review. Could you recheck it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for quick fix :) I confirmed search --no-color works! LGTM!!🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku LGTM! Thanks so much!
What Changed
--no-color
option is used.I would appreciate it if you could review when you have time.