Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed progress bar and wizard colored output when --no-color option is used #1269

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • Fixed progress bar and wizard colored output when --no-color option is used.

I would appreciate it if you could review when you have time.

@hitenkoku hitenkoku added the bug Something isn't working label Feb 3, 2024
@hitenkoku hitenkoku self-assigned this Feb 3, 2024
@hitenkoku hitenkoku linked an issue Feb 3, 2024 that may be closed by this pull request
@hitenkoku
Copy link
Collaborator Author

Evidence

image

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (19c8c06) 82.18% compared to head (9c98cfc) 82.09%.
Report is 16 commits behind head on main.

Files Patch % Lines
src/main.rs 5.40% 35 Missing ⚠️
src/timeline/search.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
- Coverage   82.18%   82.09%   -0.09%     
==========================================
  Files          27       27              
  Lines       24313    24337      +24     
==========================================
- Hits        19981    19980       -1     
- Misses       4332     4357      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku
I confirmed following command with --no-color :)

  • csv-timeline
  • json-timeline
  • eid-metrics
  • computer-metrics
  • pivot-keywords-list
  • logon-summary

It seems that only the search command is still colored. Could you please confirm?

@hitenkoku
Copy link
Collaborator Author

@fukusuket Thanks for your review.
In 9c98cfc, I fixed problem that --no-color is not enabled in search command.

Could you recheck it?

@hitenkoku hitenkoku requested a review from fukusuket February 4, 2024 13:06
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quick fix :) I confirmed search --no-color works! LGTM!!🚀

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit bda68fb into main Feb 4, 2024
7 checks passed
@hitenkoku hitenkoku deleted the 1256-no-color-not-working-for-progress-bar-and-scan-wizard branch February 4, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--no-color not working for progress bar and scan wizard
3 participants