Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed choosing some options time from elapsed time #1296

Merged
merged 3 commits into from
Mar 6, 2024
Merged

removed choosing some options time from elapsed time #1296

merged 3 commits into from
Mar 6, 2024

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • removed choosing some options time from elapsed time.

@hitenkoku hitenkoku added the bug Something isn't working label Mar 5, 2024
@hitenkoku hitenkoku self-assigned this Mar 5, 2024
@hitenkoku hitenkoku linked an issue Mar 5, 2024 that may be closed by this pull request
[bug] Elapsed time include the time that users are choosing some options before hayabusa load evtx and detect alert. #1291
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 81.06%. Comparing base (63e1f64) to head (613af35).

Files Patch % Lines
src/main.rs 72.97% 10 Missing ⚠️
src/debug/checkpoint_process_timer.rs 93.44% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage   81.05%   81.06%           
=======================================
  Files          27       27           
  Lines       24544    24626   +82     
=======================================
+ Hits        19895    19963   +68     
- Misses       4649     4663   +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

YamatoSecurity
YamatoSecurity approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

fukusuket
fukusuket approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed csv-timeline/computer-metrics works :) LGTM!!🚀

@YamatoSecurity YamatoSecurity added this to the v2.14.0 milestone Mar 6, 2024
@hitenkoku hitenkoku removed the request for review from hach1yon March 6, 2024 10:58
@hitenkoku hitenkoku merged commit ce04f24 into main Mar 6, 2024
9 checks passed
@hitenkoku hitenkoku deleted the 1291-bug-elapsed-time-include-the-time-that-users-are-choosing-some-options-before-hayabusa-load-evtx-and-detect-alert branch March 6, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoSecurity YamatoSecurity YamatoSecurity approved these changes

@fukusuket fukusuket fukusuket approved these changes

Assignees

@hitenkoku hitenkoku

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.14.0
3 participants
@hitenkoku @fukusuket @YamatoSecurity