Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matchers): added fieldref modifier #1417

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • added fieldref modifier

@hitenkoku hitenkoku added the enhancement New feature or request label Sep 19, 2024
@hitenkoku hitenkoku self-assigned this Sep 19, 2024
@hitenkoku hitenkoku linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku Thanks so much! I tested it and LGTM!

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late confirmation.I confirmed following rule works!(Not to be detected with a value that does not exist) LGTM!!🚀

detection:
    selection_basic:
        Channel: Security
        EventID: 4624       # Logon Succesful
    selection_TokenImpersonationCharacteristics:
        LogonType: 9        # New Interactive
        ImpersonationLevel|contains: 1833 # It is actually %%1833 for Impersonation level of "Impersonation".
        SubjectUserName|fieldref: TargetUserName
    condition: selection_basic and selection_TokenImpersonationCharacteristics

There is also no difference between the main and the result.
https://github.com/Yamato-Security/hayabusa/actions/runs/10958330759

@YamatoSecurity YamatoSecurity merged commit 96773a3 into main Sep 20, 2024
8 checks passed
@YamatoSecurity YamatoSecurity deleted the 1409-support-fieldref-modifier branch September 20, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support fieldref modifier
3 participants