refactor: Trade 삭제된 후 조회시 예외 메시지 변경

Trade 삭제된 후 조회시 예외 메시지 변경
Yanabada · Jan 16, 2024 · 0c62153 · 0c62153
1 parent ece9208
commit 0c62153
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/main/java/kr/co/fastcampus/yanabada/domain/payment/service/TradeService.java b/src/main/java/kr/co/fastcampus/yanabada/domain/payment/service/TradeService.java
@@ -7,6 +7,7 @@
 import kr.co.fastcampus.yanabada.common.exception.CannotTradeOwnProductException;
 import kr.co.fastcampus.yanabada.common.exception.IllegalProductStatusException;
 import kr.co.fastcampus.yanabada.common.exception.IllegalTradeStatusException;
+import kr.co.fastcampus.yanabada.common.exception.TradeNotFoundException;
 import kr.co.fastcampus.yanabada.common.utils.EntityCodeGenerator;
 import kr.co.fastcampus.yanabada.domain.member.entity.Member;
 import kr.co.fastcampus.yanabada.domain.member.repository.MemberRepository;
@@ -109,9 +110,10 @@ public ApprovalTradeInfoResponse getApprovalTrade(Long memberId, Long tradeId) {
         Member member = memberRepository.getMember(memberId);
         Trade trade = tradeRepository.getTrade(tradeId);
 
-        if (!Objects.equals(member, trade.getSeller())
-            || trade.getHasSellerDeleted()
-            || trade.getStatus() == WAITING) {
+        if (trade.getHasSellerDeleted()) {
+            throw new TradeNotFoundException();
+        }
+        if (!Objects.equals(member, trade.getSeller()) || trade.getStatus() == WAITING) {
             throw new AccessForbiddenException();
         }
 
@@ -123,9 +125,10 @@ public PurchaseTradeInfoResponse getPurchaseTrade(Long memberId, Long tradeId) {
         Member member = memberRepository.getMember(memberId);
         Trade trade = tradeRepository.getTrade(tradeId);
 
-        if (!Objects.equals(member, trade.getBuyer())
-            || trade.getHasBuyerDeleted()
-            || trade.getStatus() == WAITING) {
+        if (trade.getHasBuyerDeleted()) {
+            throw new TradeNotFoundException();
+        }
+        if (!Objects.equals(member, trade.getBuyer()) || trade.getStatus() == WAITING) {
             throw new AccessForbiddenException();
         }