refactor: 랜덤값 생성 변경 및 이미지 수정 기능 제거

Yanabada · Jan 20, 2024 · cb474f0 · cb474f0
1 parent df09162
commit cb474f0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 23 deletions.
diff --git a/src/main/java/kr/co/fastcampus/yanabada/domain/auth/service/AuthService.java b/src/main/java/kr/co/fastcampus/yanabada/domain/auth/service/AuthService.java
@@ -3,6 +3,7 @@
 import static kr.co.fastcampus.yanabada.domain.member.entity.ProviderType.EMAIL;
 import static kr.co.fastcampus.yanabada.domain.member.entity.RoleType.ROLE_USER;
 
+import java.util.Random;
 import kr.co.fastcampus.yanabada.common.exception.EmailDuplicatedException;
 import kr.co.fastcampus.yanabada.common.jwt.dto.TokenIssueResponse;
 import kr.co.fastcampus.yanabada.common.jwt.dto.TokenRefreshResponse;
@@ -78,8 +79,9 @@ public Long oauthSignUp(OauthSignUpRequest signUpRequest) {
     }
 
     private String getRandomProfileImage() {
-        int randNum = (int) ((Math.random() * 10000) % 5);
-        return randNum + "profile.png";     //todo: 환경 변수 분리
+        Random random = new Random();
+        int randomNumber = random.nextInt(5) + 1;
+        return randomNumber + "profile.png";     //todo: 환경 변수 분리
     }
 
     @Transactional

diff --git a/src/main/java/kr/co/fastcampus/yanabada/domain/member/controller/MemberController.java b/src/main/java/kr/co/fastcampus/yanabada/domain/member/controller/MemberController.java
@@ -69,17 +69,6 @@ public ResponseBody<Void> modifyPhoneNumber(
         return ResponseBody.ok();
     }
 
-    @PutMapping("/image")
-    public ResponseBody<Void> modifyImage(
-        @AuthenticationPrincipal PrincipalDetails principalDetails,
-        @RequestBody @Valid ImageModifyRequest imageRequest
-    ) {
-        memberService.modifyImage(
-            imageRequest, principalDetails.email(), principalDetails.provider()
-        );
-        return ResponseBody.ok();
-    }
-
     @PutMapping("/fcm-token")
     public ResponseBody<Void> updateFcmToken(
         @AuthenticationPrincipal PrincipalDetails principalDetails,

diff --git a/src/main/java/kr/co/fastcampus/yanabada/domain/member/service/MemberService.java b/src/main/java/kr/co/fastcampus/yanabada/domain/member/service/MemberService.java
@@ -67,16 +67,6 @@ public void modifyPhoneNumber(
         member.updatePhoneNumber(phoneNumberRequest.phoneNumber());
     }
 
-    @Transactional
-    public void modifyImage(
-        ImageModifyRequest imageRequest,
-        String email,
-        ProviderType providerType
-    ) {
-        Member member = memberRepository.getMember(email, providerType);
-        member.updateImage(imageRequest.image());
-    }
-
     @Transactional(readOnly = true)
     public EmailAuthResponse verifyEmail(
         EmailAuthRequest emailRequest