From cb474f0b9d52bf8d2f93e8bed32b4b3d00134e9b Mon Sep 17 00:00:00 2001
From: tjdtn0219 <s_sjang@naver.com>
Date: Sat, 20 Jan 2024 10:45:24 +0900
Subject: [PATCH] =?UTF-8?q?refactor:=20=EB=9E=9C=EB=8D=A4=EA=B0=92=20?=
 =?UTF-8?q?=EC=83=9D=EC=84=B1=20=EB=B3=80=EA=B2=BD=20=EB=B0=8F=20=EC=9D=B4?=
 =?UTF-8?q?=EB=AF=B8=EC=A7=80=20=EC=88=98=EC=A0=95=20=EA=B8=B0=EB=8A=A5=20?=
 =?UTF-8?q?=EC=A0=9C=EA=B1=B0?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../yanabada/domain/auth/service/AuthService.java     |  6 ++++--
 .../domain/member/controller/MemberController.java    | 11 -----------
 .../yanabada/domain/member/service/MemberService.java | 10 ----------
 3 files changed, 4 insertions(+), 23 deletions(-)

diff --git a/src/main/java/kr/co/fastcampus/yanabada/domain/auth/service/AuthService.java b/src/main/java/kr/co/fastcampus/yanabada/domain/auth/service/AuthService.java
index bd385b75..b004962a 100644
--- a/src/main/java/kr/co/fastcampus/yanabada/domain/auth/service/AuthService.java
+++ b/src/main/java/kr/co/fastcampus/yanabada/domain/auth/service/AuthService.java
@@ -3,6 +3,7 @@
 import static kr.co.fastcampus.yanabada.domain.member.entity.ProviderType.EMAIL;
 import static kr.co.fastcampus.yanabada.domain.member.entity.RoleType.ROLE_USER;
 
+import java.util.Random;
 import kr.co.fastcampus.yanabada.common.exception.EmailDuplicatedException;
 import kr.co.fastcampus.yanabada.common.jwt.dto.TokenIssueResponse;
 import kr.co.fastcampus.yanabada.common.jwt.dto.TokenRefreshResponse;
@@ -78,8 +79,9 @@ public Long oauthSignUp(OauthSignUpRequest signUpRequest) {
     }
 
     private String getRandomProfileImage() {
-        int randNum = (int) ((Math.random() * 10000) % 5);
-        return randNum + "profile.png";     //todo: 환경 변수 분리
+        Random random = new Random();
+        int randomNumber = random.nextInt(5) + 1;
+        return randomNumber + "profile.png";     //todo: 환경 변수 분리
     }
 
     @Transactional
diff --git a/src/main/java/kr/co/fastcampus/yanabada/domain/member/controller/MemberController.java b/src/main/java/kr/co/fastcampus/yanabada/domain/member/controller/MemberController.java
index ecb22d06..f409c125 100644
--- a/src/main/java/kr/co/fastcampus/yanabada/domain/member/controller/MemberController.java
+++ b/src/main/java/kr/co/fastcampus/yanabada/domain/member/controller/MemberController.java
@@ -69,17 +69,6 @@ public ResponseBody<Void> modifyPhoneNumber(
         return ResponseBody.ok();
     }
 
-    @PutMapping("/image")
-    public ResponseBody<Void> modifyImage(
-        @AuthenticationPrincipal PrincipalDetails principalDetails,
-        @RequestBody @Valid ImageModifyRequest imageRequest
-    ) {
-        memberService.modifyImage(
-            imageRequest, principalDetails.email(), principalDetails.provider()
-        );
-        return ResponseBody.ok();
-    }
-
     @PutMapping("/fcm-token")
     public ResponseBody<Void> updateFcmToken(
         @AuthenticationPrincipal PrincipalDetails principalDetails,
diff --git a/src/main/java/kr/co/fastcampus/yanabada/domain/member/service/MemberService.java b/src/main/java/kr/co/fastcampus/yanabada/domain/member/service/MemberService.java
index f992ef7d..1800c8ab 100644
--- a/src/main/java/kr/co/fastcampus/yanabada/domain/member/service/MemberService.java
+++ b/src/main/java/kr/co/fastcampus/yanabada/domain/member/service/MemberService.java
@@ -67,16 +67,6 @@ public void modifyPhoneNumber(
         member.updatePhoneNumber(phoneNumberRequest.phoneNumber());
     }
 
-    @Transactional
-    public void modifyImage(
-        ImageModifyRequest imageRequest,
-        String email,
-        ProviderType providerType
-    ) {
-        Member member = memberRepository.getMember(email, providerType);
-        member.updateImage(imageRequest.image());
-    }
-
     @Transactional(readOnly = true)
     public EmailAuthResponse verifyEmail(
         EmailAuthRequest emailRequest