-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
상품 생성 API 구현 #17
Merged
Merged
상품 생성 API 구현 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProductRepository 구현
ProductSaveRequest 구현
ProductIdResponse 구현
RoomOrder -> Order 로 클래스명 변경
ProductService의 saveProduct 메소드 구현
Product 등록시 발생하는 예외 구현
Product 등록시 발생하는 예외의 메시지 구현
ProductSaveRequest, ProductIdResponse 구현
ProductController 의 addProduct 메소드 구현
tjdtn0219
reviewed
Jan 5, 2024
src/main/java/kr/co/fastcampus/yanabada/common/exception/AccessForbiddenException.java
Outdated
Show resolved
Hide resolved
src/main/java/kr/co/fastcampus/yanabada/domain/product/entity/Product.java
Show resolved
Hide resolved
src/main/java/kr/co/fastcampus/yanabada/domain/product/service/ProductService.java
Show resolved
Hide resolved
Hwang-Kyu-Cheol
requested review from
tjdtn0219,
Programmer-may and
deltawing71911
January 5, 2024 13:21
Exception 의 Enum 메시지를 static import 로 변화
src/main/java/kr/co/fastcampus/yanabada/common/exception/MemberNotFoundException.java
Show resolved
Hide resolved
src/main/java/kr/co/fastcampus/yanabada/domain/product/service/ProductService.java
Outdated
Show resolved
Hide resolved
Programmer-may
requested changes
Jan 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이야기 나눠볼 것 적어 봤습니다! 수정 사항 반영되면 approve 하겠습니다
tjdtn0219
approved these changes
Jan 7, 2024
src/main/java/kr/co/fastcampus/yanabada/domain/product/entity/Product.java
Show resolved
Hide resolved
deltawing71911
approved these changes
Jan 7, 2024
src/main/java/kr/co/fastcampus/yanabada/domain/product/service/ProductService.java
Show resolved
Hide resolved
tjdtn0219
approved these changes
Jan 8, 2024
응답 DTO 생성 방식에 빌더 패턴과 팩토리 메소드 패턴 적용
Programmer-may
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15
개요
상품 생성 API 구현
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.