Skip to content

Navigation Menu

Explore
By size
By industry
By use case
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Yanabada / Yanabada_BE Public

Notifications You must be signed in to change notification settings
Fork 1
Star 0

Code
Issues
Pull requests
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/14 예약내역 상세 API 구현 #20

Merged

deltawing71911 merged 27 commits into develop from feature/14

Jan 10, 2024

Merged

Feature/14 예약내역 상세 API 구현 #20

deltawing71911 merged 27 commits into develop from feature/14

Jan 10, 2024

Conversation 37 Commits 27 Checks 2 Files changed

Conversation

Copy link

Contributor

deltawing71911 commented Jan 7, 2024 •

edited

Loading

개요

PR 유형

어떤 변경 사항이 있나요?

새로운 기능 추가
버그 수정
CSS 등 사용자 UI 디자인 변경
코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
코드 리팩토링
주석 추가 및 수정
문서 수정
테스트 추가, 테스트 리팩토링
빌드 부분 혹은 패키지 매니저 수정
파일 혹은 폴더명 수정
파일 혹은 폴더 삭제

PR Checklist

PR이 다음 요구 사항을 충족하는지 확인하세요.

커밋 메시지 컨벤션에 맞게 작성했습니다. Commit message convention 참고 (Ctrl + 클릭하세요.)
변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트)

Sorry, something went wrong.

All reactions

deltawing71911 added 4 commits

January 6, 2024 00:02


          feat: 예약내역 상세 응답 DTO 구현, 서비스 계층 구현

resolved #14


          feat: 예약내역 상세 컨트롤러 구현

8bf1cf8

resolved #14


          Merge branch 'develop' of https://github.com/Yanabada/Yanabada_BE int…

3b27200

…o feature/14


          feat: 읽기 전용 트랜잭션 설정

2f2a71c

resolved #14

deltawing71911 requested review from Programmer-may, Hwang-Kyu-Cheol and tjdtn0219

January 7, 2024 23:28

deltawing71911 added 2 commits

January 8, 2024 08:38


          refactor: Lexicographical Order Check 해결

0d70bc5

import문 알파벳 순서대로 다시 정렬
resolved #14


          refactor: Line Length Check 오류해결

b28b6e4

라인당 문자수 조절
resolved #14

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/controller/OrderController.java Outdated Show resolved Hide resolved

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/controller/OrderController.java Outdated Show resolved Hide resolved

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/controller/OrderController.java Outdated Show resolved Hide resolved

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/controller/OrderController.java Outdated Show resolved Hide resolved

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/dto/response/ReservationDetailsDto.java Outdated Show resolved Hide resolved

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/service/OrderService.java Outdated Show resolved Hide resolved


          refactor: 가독성 개선, 변수명 변경, Response DTO에 생성 메서드 추가

43f9a69

응답부분 리팩터링
resolved #14

tjdtn0219 approved these changes

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/dto/response/OrderInfoResponse.java Outdated Show resolved Hide resolved


          refactor: Response DTO 빌더패턴으로 변경

c2038d9

빌더패턴으로 통일
resolved #14

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/controller/OrderController.java Outdated Show resolved Hide resolved

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/service/OrderService.java Outdated Show resolved Hide resolved

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/service/OrderService.java Outdated Show resolved Hide resolved

deltawing71911 added 7 commits

January 8, 2024 12:06


          fix: 엔티티 이름 변경 및 conflict 해결

c32a3d7

resolved #14


          refactor: ResponseBody 객체를 바로 반환하도록 수정

952dbf1

resolved #14


          refactor: 예외처리 방식 변경

5a1afaf

resolved #14


          refactor: 권한없음 예외처리 추가

cea8add

내 예약내역이 아닌 다른사람의 예약내역을 조회하려고 할 때 '권한 없음' 오류를 발생시키는 로직
resolved #14


          refactor: 체크스타일 수정

b5f5c11

resolved #14


          fix: 로컬 오류 수정

8a306f7

resolved #14


          fix: 로컬 오류 수정

28185ad

resolved #14

Programmer-may reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/controller/OrderController.java Outdated Show resolved Hide resolved

Programmer-may reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/dto/response/OrderInfoResponse.java Outdated Show resolved Hide resolved

deltawing71911 added 2 commits

January 8, 2024 16:56


          refactor: DTO 수정, RoomOption 구현

23f7da3

resolved #14


          refactor: 컨벤션

1045a44

resolved #14

Hwang-Kyu-Cheol reviewed

View reviewed changes

src/main/resources/application.yml Outdated Show resolved Hide resolved

Programmer-may reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/dto/response/OrderInfoResponse.java Outdated Show resolved Hide resolved

deltawing71911 added 2 commits

January 8, 2024 18:14


          feat: RoomOptionResponse DTO 작성, 리팩토링

53879a4

resolved #14


          refactor: yml 파일 수정

51551ce

resolved #14

Programmer-may reviewed

View reviewed changes

...ain/java/kr/co/fastcampus/yanabada/domain/accommodation/dto/response/RoomOptionResponse.java Outdated Show resolved Hide resolved

Programmer-may reviewed

View reviewed changes

src/main/java/kr/co/fastcampus/yanabada/domain/order/dto/response/OrderInfoResponse.java Outdated Show resolved Hide resolved

Hwang-Kyu-Cheol reviewed

View reviewed changes

Copy link

Contributor

Hwang-Kyu-Cheol left a comment •

edited

Loading

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수지님 그리고 예약내역 상세보기 페이지에서 옵션들 없어졌습니다!(피그마에서 확인가능) 그래서 응답에 있는 RoomOption 따로 보내줄 필요 없을 것 같아요

Sorry, something went wrong.

deltawing71911 reacted with eyes emoji

All reactions

👀 1 reaction

deltawing71911 added 2 commits

January 9, 2024 14:33


          refactor: 빌더패턴 수정

ca76ebe

resolved #14


          Merge branch 'develop' of https://github.com/Yanabada/Yanabada_BE int…

593f6be

…o feature/14

Programmer-may assigned deltawing71911

Programmer-may added the enhancement New feature or request label

deltawing71911 added 3 commits

January 9, 2024 23:07


          fix: 충돌 해결

c2c4f18

resolved #14


          fix: 충돌 해결

22228c0

resolved #14


          refactor: OrderInfoResponse 필드, 메서드 수정

1933bd2

resolved #14

Hwang-Kyu-Cheol approved these changes

View reviewed changes

deltawing71911 added 3 commits

January 10, 2024 16:38


          fix: 충돌 해결

4ec85de

resolved #14


          refactor: RoomOption 관련로직 삭제

0ae1f97

조식, 무료주차 부분이 삭제되어 관련 로직을 제거하였습니다.
resolved #14


          refactor: CheckStyle 수정

2f80b3a

resolved #14

Programmer-may approved these changes

View reviewed changes

Copy link

Contributor

Programmer-may left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!!

Sorry, something went wrong.

deltawing71911 reacted with thumbs up emoji

All reactions

👍 1 reaction

deltawing71911 merged commit 92abe15 into develop

2 checks passed

deltawing71911 deleted the feature/14 branch

January 10, 2024 08:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Hwang-Kyu-Cheol Hwang-Kyu-Cheol approved these changes

tjdtn0219 tjdtn0219 approved these changes

Programmer-may Programmer-may approved these changes

Assignees

Labels

New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.