Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

예약 관련 테스트 코드 작성 #247

Merged
merged 7 commits into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public ResponseBody<List<OrderSummaryResponse>> getSellableOrders(

@GetMapping("/{orderId}")
public ResponseBody<OrderInfoResponse> getOrderInfo(
@PathVariable Long orderId,
@PathVariable("orderId") Long orderId,
@AuthenticationPrincipal PrincipalDetails principalDetails
) {
return ResponseBody.ok(orderService.getOrderInfo(orderId, principalDetails.id()));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,12 @@ public List<OrderSummaryResponse> getSellableOrders(Long memberId) {
}

@Transactional(readOnly = true)
public OrderInfoResponse getOrderInfo(Long orderId, Long currentUserId) {
public OrderInfoResponse getOrderInfo(Long orderId, Long memberId) {
Order order = orderRepository.findById(orderId)
.orElseThrow(OrderNotFoundException::new);
Member member = memberRepository.getMember(memberId);

if (!order.getMember().getId().equals(currentUserId)) {
if (!order.getMember().equals(member)) {
throw new AccessForbiddenException();
}

Expand Down
59 changes: 59 additions & 0 deletions src/test/java/kr/co/fastcampus/yanabada/common/utils/ApiTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
package kr.co.fastcampus.yanabada.common.utils;

import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createAccommodation;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createAccommodationOption;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createBuyer;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createOrder;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createRoom;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createRoomOption;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createSeller;

import kr.co.fastcampus.yanabada.domain.accommodation.entity.Accommodation;
import kr.co.fastcampus.yanabada.domain.accommodation.entity.Room;
import kr.co.fastcampus.yanabada.domain.accommodation.repository.AccommodationOptionRepository;
import kr.co.fastcampus.yanabada.domain.accommodation.repository.AccommodationRepository;
import kr.co.fastcampus.yanabada.domain.accommodation.repository.RoomOptionRepository;
import kr.co.fastcampus.yanabada.domain.accommodation.repository.RoomRepository;
import kr.co.fastcampus.yanabada.domain.member.entity.Member;
import kr.co.fastcampus.yanabada.domain.member.repository.MemberRepository;
import kr.co.fastcampus.yanabada.domain.order.entity.Order;
import kr.co.fastcampus.yanabada.domain.order.repository.OrderRepository;
import kr.co.fastcampus.yanabada.domain.product.repository.ProductRepository;
import org.junit.jupiter.api.BeforeEach;
import org.springframework.beans.factory.annotation.Autowired;

public abstract class ApiTest {

@Autowired
private MemberRepository memberRepository;

@Autowired
private AccommodationRepository accommodationRepository;

@Autowired
private AccommodationOptionRepository accommodationOptionRepository;

@Autowired
private RoomRepository roomRepository;

@Autowired
private RoomOptionRepository roomOptionRepository;

@Autowired
private OrderRepository orderRepository;

@Autowired
private ProductRepository productRepository;


@BeforeEach
public void setup() {
Accommodation accommodation = accommodationRepository.save(createAccommodation());
accommodationOptionRepository.save(createAccommodationOption(accommodation));
Room room = roomRepository.save(createRoom(accommodation));
roomOptionRepository.save(createRoomOption(room));
Member seller = memberRepository.save(createSeller());
Order order = orderRepository.save(createOrder(room, seller));
memberRepository.save(createBuyer());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,23 @@ public static Order createOrder(Room room, Member member) {
);
}

public static Member createMember() {
public static Member createSeller() {
return Member.builder()
.email("test@test.com")
.nickName("testNickname")
.password("1234")
.email("seller@test.com")
.nickName("sellerNickname")
.password("password123!")
.phoneNumber("010-1234-1234")
.roleType(ROLE_USER)
.image("a.jpg")
.providerType(EMAIL)
.build();
}

public static Member createBuyer() {
return Member.builder()
.email("buyer@test.com")
.nickName("buyerNickname")
.password("password123")
.phoneNumber("010-1234-1234")
.roleType(ROLE_USER)
.image("a.jpg")
Expand All @@ -127,4 +139,4 @@ public static Product createProduct(Order order) {
ProductStatus.ON_SALE
);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
package kr.co.fastcampus.yanabada.domain.order.controller;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

import kr.co.fastcampus.yanabada.common.security.WithMockMember;
import kr.co.fastcampus.yanabada.common.utils.ApiTest;
import kr.co.fastcampus.yanabada.domain.accommodation.repository.AccommodationOptionRepository;
import kr.co.fastcampus.yanabada.domain.accommodation.repository.AccommodationRepository;
import kr.co.fastcampus.yanabada.domain.accommodation.repository.RoomOptionRepository;
import kr.co.fastcampus.yanabada.domain.accommodation.repository.RoomRepository;
import kr.co.fastcampus.yanabada.domain.member.repository.MemberRepository;
import kr.co.fastcampus.yanabada.domain.order.repository.OrderRepository;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

@SpringBootTest
@AutoConfigureMockMvc
class OrderControllerTest extends ApiTest {

private static final MediaType MEDIA_TYPE = MediaType.APPLICATION_JSON;

@Autowired
private MockMvc mockMvc;

@Autowired
private MemberRepository memberRepository;

@Autowired
private AccommodationRepository accommodationRepository;

@Autowired
private AccommodationOptionRepository accommodationOptionRepository;

@Autowired
private RoomRepository roomRepository;

@Autowired
private RoomOptionRepository roomOptionRepository;

@Autowired
private OrderRepository orderRepository;

@DisplayName("[API][GET] 판매 가능한 예약 조회 - 정상적인 요청일 경우, 정상적으로 예약이 조회됩니다.")
@Test
@WithMockMember
void getSellableOrders_success() throws Exception {
//given
String url = "/v1/orders/can-sell";

//when
mockMvc.perform(get(url))

//then
.andExpect(status().isOk())
.andExpect(jsonPath("$.status").value("SUCCESS"))
.andExpect(jsonPath("$.data[0].id").value(1));
}

@DisplayName("[API][GET] 예약 상세 조회 - 정상적인 요청일 경우, 정상적으로 예약이 조회됩니다.")
@Test
@WithMockMember
void getOrderInfo_success() throws Exception {
//given
String url = "/v1/orders/1";

//when
mockMvc.perform(get(url))

//then
.andExpect(status().isOk())
.andExpect(jsonPath("$.status").value("SUCCESS"))
.andExpect(jsonPath("$.data.orderId").value(1));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
package kr.co.fastcampus.yanabada.domain.order.service;

import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createAccommodation;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createAccommodationOption;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createOrder;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createRoom;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createRoomOption;
import static kr.co.fastcampus.yanabada.common.utils.TestUtils.createSeller;
import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.BDDMockito.given;

import java.util.List;
import java.util.Optional;
import kr.co.fastcampus.yanabada.domain.accommodation.entity.Accommodation;
import kr.co.fastcampus.yanabada.domain.accommodation.entity.AccommodationOption;
import kr.co.fastcampus.yanabada.domain.accommodation.entity.Room;
import kr.co.fastcampus.yanabada.domain.accommodation.entity.RoomOption;
import kr.co.fastcampus.yanabada.domain.member.entity.Member;
import kr.co.fastcampus.yanabada.domain.member.repository.MemberRepository;
import kr.co.fastcampus.yanabada.domain.order.dto.response.OrderInfoResponse;
import kr.co.fastcampus.yanabada.domain.order.dto.response.OrderSummaryResponse;
import kr.co.fastcampus.yanabada.domain.order.entity.Order;
import kr.co.fastcampus.yanabada.domain.order.repository.OrderRepository;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;

@ExtendWith(MockitoExtension.class)
class OrderServiceTest {

@Mock
private OrderRepository orderRepository;

@Mock
private MemberRepository memberRepository;

@InjectMocks
private OrderService orderService;

@DisplayName("판매가능한 상품이 있을 경우, 해당 상품을 반환합니다.")
@Test
void getSellableOrders() {
//given
Accommodation accommodation = createAccommodation();
AccommodationOption accommodationOption = createAccommodationOption(accommodation);
accommodation.registerAccommodationOption(accommodationOption);
Room room = createRoom(accommodation);
RoomOption roomOption = createRoomOption(room);
room.registerRoomOption(roomOption);
accommodation.addRoom(room);
Member member = createSeller();
Order order = createOrder(room, member);
given(memberRepository.getMember(1L)).willReturn(member);
given(orderRepository.getSellableByMember(member)).willReturn(List.of(order));

//when
List<OrderSummaryResponse> sellableOrders = orderService.getSellableOrders(1L);

//then
assertThat(sellableOrders).isNotEmpty();
}

@DisplayName("정상적인 예약 상세 조회일 경우, 해당 예약을 반환합니다.")
@Test
void getOrderInfo() {
//given
Accommodation accommodation = createAccommodation();
AccommodationOption accommodationOption = createAccommodationOption(accommodation);
accommodation.registerAccommodationOption(accommodationOption);
Room room = createRoom(accommodation);
RoomOption roomOption = createRoomOption(room);
room.registerRoomOption(roomOption);
accommodation.addRoom(room);
Member member = createSeller();
Order order = createOrder(room, member);
given(orderRepository.findById(1L)).willReturn(Optional.of(order));
given(memberRepository.getMember(1L)).willReturn(member);

//when
OrderInfoResponse orderInfo = orderService.getOrderInfo(1L, 1L);

//then
assertThat(orderInfo).isNotNull();
}
}
Loading