-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
채팅 메세지 송/수신 API 구현 #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
웹소켓 연결을 위한 의존성 주입 1 웹소켓 2 stomp 3 SockJS
웹소켓 컨피그 구현
수신 메세지 DTO 구현
송신 메세지 DTO 구현
채팅 메세지 송/수신 API 구현
채팅 메세지 송/수신 API 비지니스 로직 구현
DTO 생성 메소드명 컨벤션에 맞게 from()으로 수정
DTO 생성 메소드명 수정에 따른 서비스 계층에서 메소드 명 수정
주석문 순서 변경
Programmer-may
requested review from
Hwang-Kyu-Cheol,
tjdtn0219 and
deltawing71911
January 14, 2024 15:34
주석문 제거
리스트에 add할때 엔티티에 만들어둔 메소드를 활용하게끔 리팩토링
src/main/java/kr/co/fastcampus/yanabada/domain/chat/dto/ReceivedChatMessage.java
Show resolved
Hide resolved
Hwang-Kyu-Cheol
approved these changes
Jan 14, 2024
메세지 보냈을 시 상대방이 채팅방 나가 있는 상태면 다시 불러오는 메소드 추가
deltawing71911
approved these changes
Jan 15, 2024
tjdtn0219
approved these changes
Jan 15, 2024
src/main/java/kr/co/fastcampus/yanabada/domain/chat/controller/ChatController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #61
개요
웹소켓 연결을 기반으로 STOMP 통신으로 채팅을 실시간으로 주고 받을 수 있게 하였습니다.
웹소켓이 지원하지 않는 브라우저에선 SockJS가 대신해줄 수 있게 했습니다.
DTO 생성 메소드 명을 from()으로 수정하였습니다.
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.