거래 내역 상세 조회 및 삭제 API 구현 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
거래내역 상세 조회 응답 DTO 구현
TradeService 의 거래내역 상세 조회 응답 및 삭제 메소드 구현
TradeController 의 거래내역 상세 조회 응답 및 삭제 메소드 구현
Trade 의 삭제 상태 변경 메소드 구현
Trade 삭제된 후 조회시 예외 메시지 변경
Hwang-Kyu-Cheol
requested review from
tjdtn0219,
Programmer-may and
deltawing71911
Comment on lines
+143
to
+148
| if (Objects.equals(member, trade.getSeller())) { | ||
| trade.deleteBySeller(); | ||
| } else if (Objects.equals(member, trade.getBuyer())) { | ||
| trade.deleteByBuyer(); | ||
| } else { | ||
| throw new AccessForbiddenException(); |
There was a problem hiding this comment.
규철님 이렇게 하면 거래에 구매자와 판매자가 나갔다는 필드만 변경되고 둘다 삭제했을 시 레코드는 삭제 되지 않아서 데이터 공간 낭비라 생각됩니다. 제 채팅방 나가기 처럼 내가 구매자면 판매자가 나갔는지 확인하고 나갔으면 레포에서 아예삭제 안 나갔으면 필드값 변경으로 가야할 거 같습니다! 채팅방 딜리트 메소드쪽 참고 부탁드려용
There was a problem hiding this comment.
옙!! 참고해서 수정하겠습니다
src/main/java/kr/co/fastcampus/yanabada/domain/payment/service/TradeService.java
Show resolved
Hide resolved
판매자 구매자 모두 trade 삭제 시 실제 DB 에서 거래내역 삭제
deltawing71911
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #83
개요
거래 내역 상세 조회 및 삭제 API 구현
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.