야놀자 페이 패스워드 설정 API 구현 #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolved #86
deltawing71911
requested review from
Hwang-Kyu-Cheol,
tjdtn0219 and
Programmer-may
resolved #86
src/main/java/kr/co/fastcampus/yanabada/domain/payment/controller/YanoljaPayController.java
Outdated
Show resolved
Hide resolved
resolved #86
src/main/java/kr/co/fastcampus/yanabada/domain/payment/controller/YanoljaPayController.java
Outdated
Show resolved
Hide resolved
src/main/java/kr/co/fastcampus/yanabada/domain/payment/controller/YanoljaPayController.java
Outdated
Show resolved
Hide resolved
src/main/java/kr/co/fastcampus/yanabada/domain/payment/service/YanoljaPayService.java
Outdated
Show resolved
Hide resolved
src/main/java/kr/co/fastcampus/yanabada/domain/payment/service/YanoljaPayService.java
Outdated
Show resolved
Hide resolved
resolved #86
src/main/java/kr/co/fastcampus/yanabada/domain/payment/repository/YanoljaPayRepository.java
Outdated
Show resolved
Hide resolved
resolved #86
Hwang-Kyu-Cheol
approved these changes
Jan 17, 2024
tjdtn0219
approved these changes
Jan 17, 2024
Comment on lines
+11
to
+18
| String password, | ||
| @NotBlank(message = "확인용 패스워드도 공백일 수 없습니다.") | ||
| String confirmPassword | ||
| ) { | ||
|
|
||
| public boolean isPasswordMatch() { | ||
| return this.password.equals(this.confirmPassword); | ||
| } |
There was a problem hiding this comment.
패스워드 == 확인용 패스워드 검증을 프론트에서 하고, 실제 서버에서는 패스워드 하나만 받을 수 있지 않나요?
There was a problem hiding this comment.
이게 지금 페이 은행 등록시에 비번, 확인용 비번인가요?
만약 맞다면 저도 성수님 의견에 동감합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #86
개요
야놀자 페이에서 사용할 비밀번호 등록 / 한 번 더 확인하는 API 구현
PR 유형
어떤 변경 사항이 있나요?
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.