-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
야놀자 페이 패스워드 설정 API 구현 #87
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4c904f0
refactor: 커스텀에러 추가, DTO 구현, 컨트롤러, 서비스 구현
deltawing71911 be1cdee
refactor: 리뷰독 체크스타일 수정
deltawing71911 24f307f
refactor: url 수정
deltawing71911 9b544fb
refactor: 메서드명 수정, 서비스 리팩토링
deltawing71911 ba69a84
refactor: 불필요한 메서드 삭제
deltawing71911 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
src/main/java/kr/co/fastcampus/yanabada/common/exception/PasswordConfirmationException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package kr.co.fastcampus.yanabada.common.exception; | ||
|
||
import static kr.co.fastcampus.yanabada.common.response.ErrorCode.PASSWORD_CONFIRMATION_DOES_NOT_MATCH; | ||
|
||
public class PasswordConfirmationException extends BaseException { | ||
public PasswordConfirmationException() { | ||
super(PASSWORD_CONFIRMATION_DOES_NOT_MATCH.getMessage()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
...ain/java/kr/co/fastcampus/yanabada/domain/payment/dto/request/PayPasswordSaveRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package kr.co.fastcampus.yanabada.domain.payment.dto.request; | ||
|
||
import jakarta.validation.constraints.NotBlank; | ||
import jakarta.validation.constraints.Pattern; | ||
import lombok.Builder; | ||
|
||
@Builder | ||
public record PayPasswordSaveRequest( | ||
@NotBlank(message = "패스워드는 공백일 수 없습니다.") | ||
@Pattern(regexp = "\\d{6}", message = "패스워드는 6글자이어야 합니다.") | ||
String password, | ||
@NotBlank(message = "확인용 패스워드도 공백일 수 없습니다.") | ||
String confirmPassword | ||
) { | ||
|
||
public boolean isPasswordMatch() { | ||
return this.password.equals(this.confirmPassword); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
src/main/java/kr/co/fastcampus/yanabada/domain/payment/repository/YanoljaPayRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,17 @@ | ||
package kr.co.fastcampus.yanabada.domain.payment.repository; | ||
|
||
import io.lettuce.core.dynamic.annotation.Param; | ||
import jakarta.validation.constraints.Pattern; | ||
import java.util.Optional; | ||
import kr.co.fastcampus.yanabada.domain.member.entity.Member; | ||
import kr.co.fastcampus.yanabada.domain.payment.entity.YanoljaPay; | ||
import org.springframework.data.jpa.repository.JpaRepository; | ||
import org.springframework.data.jpa.repository.Modifying; | ||
import org.springframework.data.jpa.repository.Query; | ||
|
||
public interface YanoljaPayRepository extends JpaRepository<YanoljaPay, Long> { | ||
|
||
Optional<YanoljaPay> findByMember(Member member); | ||
|
||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
패스워드 == 확인용 패스워드 검증을 프론트에서 하고, 실제 서버에서는 패스워드 하나만 받을 수 있지 않나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이게 지금 페이 은행 등록시에 비번, 확인용 비번인가요?
만약 맞다면 저도 성수님 의견에 동감합니다