Skip to content

Commit

Permalink
Merge pull request #191 from Yoast/feature/2.x/ghactions-stop-testing…
Browse files Browse the repository at this point in the history
…-against-phpunit-dev

2.x | GH Actions: remove the trial run against PHPUnit 11
  • Loading branch information
hellofromtonya authored Sep 6, 2024
2 parents 0faa897 + 65033b0 commit 58efe02
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,6 @@ jobs:
coverage: false
experimental: true

- php: '8.3'
phpunit: 'dev-main' # PHPUnit 11.x
coverage: false
experimental: true

name: "Tests: PHP ${{ matrix.php }} - PHPUnit: ${{matrix.phpunit}}"

continue-on-error: ${{ matrix.experimental }}
Expand Down Expand Up @@ -162,10 +157,7 @@ jobs:
- name: Determine PHPUnit config
id: phpunit_config
run: |
if [ "${{ matrix.phpunit == 'dev-main' }}" == "true" ]; then
echo 'FILE=phpunit10.xml.dist' >> $GITHUB_OUTPUT
echo 'NEEDS_MIGRATION=true' >> $GITHUB_OUTPUT
elif [ "${{ steps.phpunit_version.outputs.VERSION }}" == "10.0" ]; then
if [ "${{ steps.phpunit_version.outputs.VERSION }}" == "10.0" ]; then
echo 'FILE=phpunit10.xml.dist' >> $GITHUB_OUTPUT
elif [ "${{ startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }}" == "true" ]; then
echo 'FILE=phpunit10.xml.dist' >> $GITHUB_OUTPUT
Expand All @@ -182,8 +174,6 @@ jobs:
run: vendor/bin/phpunit -c ${{ steps.phpunit_config.outputs.FILE }} --migrate-configuration

- name: "Run the unit tests"
# Don't fail the build on a test run failure against a future PHPUnit version.
continue-on-error: ${{ matrix.phpunit == 'dev-main' }}
run: >
vendor/bin/phpunit -c ${{ steps.phpunit_config.outputs.FILE }}
${{ ! matrix.coverage && '--no-coverage' || '' }}
Expand Down

0 comments on commit 58efe02

Please sign in to comment.