Tests: tweaks to work round PHP 8.4 deprecation #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a `null` default value, which are not explicitly declared as nullable. The `ValueObject` fixture used in these tests used one such implicitly nullable parameters. The tests for the `AssertObjectEquals` trait already needed two test classes to allow the method to be fully tests cross-version: * One set which was run on PHPUnit < 9.4.0. * One set which runs against PHP 7.0+. As the nullability operator was introduced in PHP 7.1 and the particular test affected _does_ need to be typed to still test what it is supposed to test, I'm changing the requirements both test sets: * The requirement for the first set of tests will now be PHPUnit < 9.4.0 AND PHP < 8.4. * The requirement for the second set of test will now be PHP 7.1+. This way the tests still covers the trait sufficiently. _Note: the trait itself is not affected by the deprecation._
jrfnl
deleted the
feature/assertobjectequalstests-fix-php-8.4-deprecation
branch
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a
nulldefault value, which are not explicitly declared as nullable.The
ValueObjectfixture used in these tests used one such implicitly nullable parameters.The tests for the
AssertObjectEqualstrait already needed two test classes to allow the method to be fully tests cross-version:As the nullability operator was introduced in PHP 7.1 and the particular test affected does need to be typed to still test what it is supposed to test, I'm changing the requirements both test sets:
This way the tests still covers the trait sufficiently.
Note: the trait itself is not affected by the deprecation.