Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: add expectDeprecation*() et al to FAQ > Removed functionality #187

Merged
merged 1 commit into from
Sep 6, 2024
Merged

README: add expectDeprecation*() et al to FAQ > Removed functionality #187

merged 1 commit into from
Sep 6, 2024

Conversation

hellofromtonya
Copy link
Collaborator

…without PHPUnit native replacement.

@hellofromtonya hellofromtonya force-pushed the documentation/custom-approach-expectdeprecations branch from d0cc20e to 2ec22bd Compare September 5, 2024 21:03
@hellofromtonya hellofromtonya linked an issue Sep 5, 2024 that may be closed by this pull request
expectDeprecation*(): Document custom extension + events approach for PHPUnit 10 #185
Closed
@coveralls
Copy link

coveralls commented Sep 5, 2024 •
edited
Loading

Coverage Status

coverage: 95.833%. remained the same
when pulling bc4373f on documentation/custom-approach-expectdeprecations
into 44560db on 2.x.

@hellofromtonya hellofromtonya force-pushed the documentation/custom-approach-expectdeprecations branch 2 times, most recently from 92419a5 to 2fbfd50 Compare September 5, 2024 21:20
@jrfnl jrfnl added this to the 2.x Next milestone Sep 5, 2024
@hellofromtonya hellofromtonya removed a link to an issue Sep 6, 2024
expectDeprecation*(): Document custom extension + events approach for PHPUnit 10 #185
Closed
@hellofromtonya hellofromtonya linked an issue Sep 6, 2024 that may be closed by this pull request
[FR] Handle expectDeprecation*() et al methods removed by PHPUnit 10 #186
Closed
@hellofromtonya hellofromtonya force-pushed the documentation/custom-approach-expectdeprecations branch 2 times, most recently from 34a4d75 to 23c29ae Compare September 6, 2024 15:46
@hellofromtonya hellofromtonya force-pushed the documentation/custom-approach-expectdeprecations branch from 23c29ae to bc4373f Compare September 6, 2024 15:48
@hellofromtonya hellofromtonya changed the title README: add expectDeprecation*() to FAQ > Removed functionality README: add expectDeprecation*() et al to FAQ > Removed functionality Sep 6, 2024
jrfnl
jrfnl approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@jrfnl jrfnl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live reviewed in a call. Thanks @hellofromtonya for this and for the amazing write-up!

@jrfnl jrfnl merged commit 10967e3 into 2.x Sep 6, 2024
158 checks passed
@jrfnl jrfnl deleted the documentation/custom-approach-expectdeprecations branch September 6, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
Type: documentation
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

[FR] Handle expectDeprecation*() et al methods removed by PHPUnit 10
3 participants
@hellofromtonya @coveralls @jrfnl