Merge pull request #141 from Yoast/JRF/QA/tests-abstract-or-final

Tests: make all classes either abstract or final
Yoast · Sep 26, 2023 · 54900d1 · 54900d1
2 parents 6ea82d8 + 36420e4
commit 54900d1
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 9 deletions.
diff --git a/tests/ConfigurationTest.php b/tests/ConfigurationTest.php
@@ -8,7 +8,7 @@
 /**
  * Configuration unit tests.
  */
-class ConfigurationTest extends Whip_TestCase {
+final class ConfigurationTest extends Whip_TestCase {
 
 	/**
 	 * Tests the creation of a Whip_Configuration with invalid input.

diff --git a/tests/MessageDismisserTest.php b/tests/MessageDismisserTest.php
@@ -8,7 +8,7 @@
 /**
  * Message Dismisser unit tests.
  */
-class MessageDismisserTest extends Whip_TestCase {
+final class MessageDismisserTest extends Whip_TestCase {
 
 	/**
 	 * Tests if Whip_MessageDismisser correctly updates Whip_DismissStorage.

diff --git a/tests/MessageTest.php b/tests/MessageTest.php
@@ -8,7 +8,7 @@
 /**
  * Message Unit tests.
  */
-class MessageTest extends Whip_TestCase {
+final class MessageTest extends Whip_TestCase {
 
 	/**
 	 * Tests if Whip_BasicMessage correctly handles a string for its body argument.

diff --git a/tests/MessagesManagerTest.php b/tests/MessagesManagerTest.php
@@ -8,7 +8,7 @@
 /**
  * Message Manager unit tests.
  */
-class MessagesManagerTest extends Whip_TestCase {
+final class MessagesManagerTest extends Whip_TestCase {
 
 	/**
 	 * Creates a MessagesManager, calls hasMessages and tests if it returns false

diff --git a/tests/RequirementsCheckerTest.php b/tests/RequirementsCheckerTest.php
@@ -8,7 +8,7 @@
 /**
  * Requirements checker unit tests.
  */
-class RequirementsCheckerTest extends Whip_TestCase {
+final class RequirementsCheckerTest extends Whip_TestCase {
 
 	/**
 	 * Tests if Whip_RequirementsChecker is successfully created when given valid arguments.

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -8,7 +8,7 @@
 /**
  * Base test case class from which all tests should extend.
  */
-class Whip_TestCase extends PHPUnit_Framework_TestCase {
+abstract class Whip_TestCase extends PHPUnit_Framework_TestCase {
 
 	/**
 	 * Helper method to test exceptions.

diff --git a/tests/VersionRequirementTest.php b/tests/VersionRequirementTest.php
@@ -8,7 +8,7 @@
 /**
  * Version requirements unit tests.
  */
-class VersionRequirementTest extends Whip_TestCase {
+final class VersionRequirementTest extends Whip_TestCase {
 
 	/**
 	 * Creates a new Whip_VersionRequirement with component php and version 5.2 and

diff --git a/tests/WPMessageDismissListenerTest.php b/tests/WPMessageDismissListenerTest.php
@@ -10,7 +10,7 @@
  *
  * @coversDefaultClass Whip_WPMessageDismissListener
  */
-class WPMessageDismissListener extends Whip_TestCase {
+final class WPMessageDismissListener extends Whip_TestCase {
 
 	/**
 	 * Tests the listen method.

diff --git a/tests/doubles/Whip_DismissStorageMock.php b/tests/doubles/Whip_DismissStorageMock.php
@@ -8,7 +8,7 @@
 /**
  * Test helper.
  */
-class Whip_DismissStorageMock implements Whip_DismissStorage {
+final class Whip_DismissStorageMock implements Whip_DismissStorage {
 
 	/**
 	 * Holds the dismissed state.