Merge pull request #146 from Yoast/JRF/whip_requirement-stablize-inte…

…rface Whip_Requirement: be explicit about all expected methods
Yoast · Oct 2, 2023 · 68f867b · 68f867b
2 parents 0b30c05 + ba6e94f
commit 68f867b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/src/interfaces/Whip_Requirement.php b/src/interfaces/Whip_Requirement.php
@@ -16,4 +16,18 @@ interface Whip_Requirement {
 	 * @return string The component name.
 	 */
 	public function component();
+
+	/**
+	 * Gets the components version defined for the requirement.
+	 *
+	 * @return string
+	 */
+	public function version();
+
+	/**
+	 * Gets the operator to use when comparing version numbers.
+	 *
+	 * @return string The comparison operator.
+	 */
+	public function operator();
 }
diff --git a/tests/ConfigurationTest.php b/tests/ConfigurationTest.php
@@ -33,7 +33,7 @@ public function testItThrowsAnErrorIfAFaultyConfigurationIsPassed() {
 	public function testItReturnsANegativeNumberIfRequirementCannotBeFound() {
 		$configuration = new Whip_Configuration( array( 'php' => '5.6' ) );
 		$requirement   = $this->getMockBuilder( 'Whip_Requirement' )
-			->setMethods( array( 'component' ) )
+			->setMethods( array( 'component', 'version', 'operator' ) )
 			->getMock();
 
 		$requirement
@@ -54,7 +54,7 @@ public function testItReturnsANegativeNumberIfRequirementCannotBeFound() {
 	public function testItReturnsAnEntryIfRequirementIsFound() {
 		$configuration = new Whip_Configuration( array( 'php' => '5.6' ) );
 		$requirement   = $this->getMockBuilder( 'Whip_Requirement' )
-			->setMethods( array( 'component' ) )
+			->setMethods( array( 'component', 'version', 'operator' ) )
 			->getMock();
 
 		$requirement
@@ -75,7 +75,7 @@ public function testItReturnsAnEntryIfRequirementIsFound() {
 	public function testIfRequirementIsConfigured() {
 		$configuration = new Whip_Configuration( array( 'php' => '5.6' ) );
 		$requirement   = $this->getMockBuilder( 'Whip_Requirement' )
-			->setMethods( array( 'component' ) )
+			->setMethods( array( 'component', 'version', 'operator' ) )
 			->getMock();
 
 		$requirement
@@ -84,7 +84,7 @@ public function testIfRequirementIsConfigured() {
 			->will( $this->returnValue( 'php' ) );
 
 		$falseRequirement = $this->getMockBuilder( 'Whip_Requirement' )
-			->setMethods( array( 'component' ) )
+			->setMethods( array( 'component', 'version', 'operator' ) )
 			->getMock();
 
 		$falseRequirement