Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

132 whip php 81 improvements #133

Merged
merged 7 commits into from
Aug 23, 2023
Merged

132 whip php 81 improvements #133

merged 7 commits into from
Aug 23, 2023

Conversation

vraja-pro
Copy link
Contributor

Context

  • Remove filter_input usage.

Summary

This PR can be summarized in the following changelog entry:

  • Removes filter_input usage for PHP 8.1 improvements.

Relevant technical choices:

  • Wrapped the wp_verify_nonce in the Whip_MessageDismisser for testing purposes.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • This PR has only unit tests.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #132

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5678878861

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.2%) to 27.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Whip_MessageDismisser.php 0 1 0.0%
Totals Coverage Status
Change from base Build 5066286864: 5.2%
Covered Lines: 67
Relevant Lines: 241

💛 - Coveralls

Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me CR 👍

@thijsoo thijsoo added this to the 1.x Next Release milestone Aug 23, 2023
@thijsoo thijsoo merged commit f8d7976 into main Aug 23, 2023
15 checks passed
@thijsoo thijsoo deleted the 132-whip-php-81-improvements branch August 23, 2023 07:08
@enricobattocchi enricobattocchi modified the milestones: 1.x Next Release, 2.0 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WHIP: PHP 8.1 improvements
4 participants