Whip_MessageDismisser::verifyNonce(): bug fix #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is documented as returning a boolean value, but the `wp_verify_nonce()` function returns `int|false`. Fixed now. Ref: https://developer.wordpress.org/reference/functions/wp_verify_nonce/ Note: as the test suite does not test with a real WP setup, this bug currently cannot easily be proven, nor safeguarded via a test. The `WHIP_WPMessageDismissListener::listen()` method uses this function and does have a test, but mocks away the `Whip_MessageDismisser::verifyNonce()` method. The mock correctly returns `true|false`, but that isn't what the reality was doing.
Pull Request Test Coverage Report for Build 6312539342
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is documented as returning a boolean value, but the
wp_verify_nonce()function returnsint|false.Fixed now.
Ref: https://developer.wordpress.org/reference/functions/wp_verify_nonce/
Note: as the test suite does not test with a real WP setup, this bug currently cannot easily be proven, nor safeguarded via a test.
The
WHIP_WPMessageDismissListener::listen()method uses this function and does have a test, but mocks away theWhip_MessageDismisser::verifyNonce()method. The mock correctly returnstrue|false, but that isn't what the reality was doing./cc @vraja-pro