CS/check thresholds: require exact match for thresholds #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the implementation of the coding standards threshold check to require that both the `YOASTCS_THRESHOLD_ERRORS` environment variable, as well as the `YOASTCS_THRESHOLD_WARNINGS` environment variable match the current status exactly. This prevents PR A fixing some issues and forgetting to update the threshold, which then would allow PR B to introduce new issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the implementation of the coding standards threshold check to require that both the
YOASTCS_THRESHOLD_ERRORSenvironment variable, as well as theYOASTCS_THRESHOLD_WARNINGSenvironment variable match the current status exactly.This prevents PR A fixing some issues and forgetting to update the threshold, which then would allow PR B to introduce new issues.
Note: WHIP currently doesn't use the threshold check in CI as the package is "clean". This commit just makes sure that the threshold implementation is in line with that in other plugins for consistency.