Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for converting Turkish keyphrases starting on İ and I to lower case. #21980

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

hannaw93
Copy link
Contributor

@hannaw93 hannaw93 commented Jan 20, 2025

Context

  • In Turkish, the same letter that is used as upper case for the Latin i is used as upper case for the Turkish dotless ı, so we get different behaviour for I:

In Turkish:
Uppercase Lowercase
I U+0049 ı U+0131
İ U+0130 i U+0069

In the Latin alphabet:
Uppercase Lowercase
I U+0049 i U+0069`

This causes confusion in what we expect when an upper case latin I is used, which is also the upper case version of ı. Tests were added to make the behaviour of Turkish keyphrases starting with capitalized dotted or dotlessi more clear.

Summary

This PR can be summarized in the following changelog entry:

  • Adds tests for converting Turkish keyphrases starting on capitalised İ and ı to lower case.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #https://github.com/Yoast/lingo-other-tasks/issues/407

@hannaw93 hannaw93 added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog technical-debt labels Jan 23, 2025
@hannaw93 hannaw93 marked this pull request as ready for review January 23, 2025 15:02
@hannaw93 hannaw93 changed the title Fix stemming of words starting with upper case i and ı in Turkish Adds tests for converting Turkish keyphrases starting on İ and I to lower case. Jan 23, 2025
@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 4acb0ba4587f365def87793098bdecd311616460

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 407-fix-turkish-nouns-with-apostrophes-starting-on-i at 57.493%

Totals Coverage Status
Change from base Build f7f95dc739fe7266db4edb615d5011d551edaa57: 57.5%
Covered Lines: 13426
Relevant Lines: 23009

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog technical-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants