-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export inclusive language csv contents #21987
base: trunk
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 25684be2df1ec3c3709d692487b889d1b619eb89Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, let's improve a little bit more by limiting the output further and adhering to the coding standards! 👍 Please also read https://yoast.atlassian.net/wiki/spaces/LIN/pages/2464317534/Development+DoD to further improve the pull request (e.g. add a label, add a changelog, etc.).
@@ -30,6 +30,7 @@ | |||
"build:types": "tsc", | |||
"clean": "rm -rf build", | |||
"pretest": "grunt get-premium-configuration", | |||
"export:inclusive-language": "jest inclusiveLanguage", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this more specific so that only the export is run.
if ( doExport ) { | ||
writeToTempFile( "inclusive-language-database.csv", resultLines.join( "\n" ) ); | ||
console.log("result=== \n"+resultLines.join( "\n" )); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the formatting of this line, and temporarily disable the eslint rule that adds a warning for console.log
statements (see https://stackoverflow.com/a/34215841).
Context
Summary
This action would allow the creation of the CSV file contents with the inclusive language configuration. This action can be triggered from the GitHub interface.
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
You can run a demo by visiting the workflow on this forked repository: https://github.com/rohans456/wordpress-seo/actions/workflows/generate_csv.yml
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #