Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPCSUtils dependency and implement the use of it #157

Closed
jrfnl opened this issue Oct 31, 2019 · 1 comment · Fixed by #322
Closed

Add PHPCSUtils dependency and implement the use of it #157

jrfnl opened this issue Oct 31, 2019 · 1 comment · Fixed by #322
Milestone

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Oct 31, 2019

A lot of the utility functions for PHPCS which I've written over the years and are included in WPCS and/or PHPCompatibility will soon be published in a separate repo called PHPCSUtils.

Once that repo has been published and the first version is tagged, this repo should become a require dependency for YoastCS and use of the utility methods in that repo should be implemented.

Both WPCS as well as PHPCompatibility will start using that repo too in their next major release.

The YoastCS version which implements PHPCSUtils should be a new major release and should at the same time update the WPCS and PHPCompatibility dependencies to the versions using PHPCSUtils as well.

@jrfnl
Copy link
Collaborator Author

jrfnl commented Apr 8, 2020

Related to #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant