Tools/BrainMonkeyRaceCondition: various improvements #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.... as extending the WPCS sniff is now no longer needed, as the utility functions we used from that sniff before, have all been replaced with utilities from PHPCSUtils.
The commit in PR 322 in which the function call retrieving the parameter was changed from the WPCS method to the PHPCSUtils method already added support for this. This commit just adds some tests to safeguard it.
As we're only looking for a _method_ in a _class_, this condition will never happen under normal circumstances, not even in case of live coding as the function declaration would not be recognized as a _method_ in that case, so the sniff would bow out before reaching this condition. All the same, there's always to possibility that this could happen if PHP adds some new syntax and the PHPCS tokenizer does not support it yet or if there is another Tokenizer issue, so I'm keeping the condition, but marking it as fine to ignore for code coverage.
jrfnl
deleted the
JRF/yoastcs-brainmonkeyracecondition-various-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools/BrainMonkeyRaceCondition: simplify/use PHPCSUtils in more places
Tools/BrainMonkeyRaceCondition: decouple from WPCS sniff
.... as extending the WPCS sniff is now no longer needed, as the utility functions we used from that sniff before, have all been replaced with utilities from PHPCSUtils.
Tools/BrainMonkeyRaceCondition: add tests with PHP 8.0+ named parameters
The commit in PR #322 in which the function call retrieving the parameter was changed from the WPCS method to the PHPCSUtils method already added support for this.
This commit just adds some tests to safeguard it.
Tools/BrainMonkeyRaceCondition: minor tweak
As we're only looking for a method in a class, this condition will never happen under normal circumstances, not even in case of live coding as the function declaration would not be recognized as a method in that case, so the sniff would bow out before reaching this condition.
All the same, there's always to possibility that this could happen if PHP adds some new syntax and the PHPCS tokenizer does not support it yet or if there is another Tokenizer issue, so I'm keeping the condition, but marking it as fine to ignore for code coverage.