Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizing 'collapse_mutationless_edges' and small fitchcount bugfix #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

richardyz98
Copy link
Collaborator

This pull request includes the generalization of the collapse_mutationless_edges function. This allows us to use a function that does not factor in missing data when determining whether to collapse two nodes. If we do not collapse on missing data, then the baseline score increases for trees as missing data increases.

Additionally, it fixes a small bug in fitchcount which can error if no root is provided, such as on an initial call of the function.

@richardyz98 richardyz98 self-assigned this May 25, 2022
@richardyz98 richardyz98 added enhancement New feature or request bug Something isn't working labels May 25, 2022
@richardyz98 richardyz98 changed the title Generalizing 'collapse_mutationless_edges' and small bugfix Generalizing 'collapse_mutationless_edges' and small fitchcount bugfix May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #181 (8a3d4d9) into master (0bd3126) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   87.40%   87.18%   -0.23%     
==========================================
  Files          72       72              
  Lines        5631     5633       +2     
==========================================
- Hits         4922     4911      -11     
- Misses        709      722      +13     
Impacted Files Coverage Δ
cassiopeia/data/CassiopeiaTree.py 91.50% <100.00%> (+0.02%) ⬆️
cassiopeia/tools/small_parsimony.py 98.51% <100.00%> (ø)
cassiopeia/solver/HybridSolver.py 75.00% <0.00%> (-9.49%) ⬇️
cassiopeia/solver/MaxCutGreedySolver.py 93.47% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd3126...8a3d4d9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant