Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RNG seed initialization when passed as a parameter #1383

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

meiniKi
Copy link
Contributor

@meiniKi meiniKi commented Oct 9, 2024

Fixes the rngstate assignment for DeterministicRNG when the seed is passed as a parameter. Assigning a seed of zero should be avoided as it leads to a constant zero output that can cause infinite loops, e.g.,

while (u1 < 1e-5)
u1 = ctx->rngf(1.0f);

@gatecat gatecat merged commit cf42baa into YosysHQ:master Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants