Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_verilog: Lower $bwmux in expr mode #4752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

povik
Copy link
Member

@povik povik commented Nov 15, 2024

What are the reasons/motivation for this change?

write_verilog doesn't know how to directly write an expression for $bwmux cells, so those are printed as an internall cell even if outside the -noexpr mode. To address, call bwmuxmap like we do to the same effect in btor/firrtl/smv backends.

Fixes #4751

@povik
Copy link
Member Author

povik commented Nov 15, 2024

From the CI:

xprop_bwmux_1: mismatch
output differences:
  - sim sim_xprop vsim_expr_xprop vsim_noexpr vsim_noexpr_xprop sat sat_xprop opt_expr opt_expr_xprop
  - vsim_expr
make[1]: *** [run-test.mk:689: xprop_bwmux_1] Error 1
make[1]: *** Waiting for unfinished jobs....
xprop_pmux_3_1: ok
xprop_pmux_3_1: ok
xprop_bwmux_3: mismatch
output differences:
  - sim sim_xprop vsim_expr_xprop vsim_noexpr vsim_noexpr_xprop sat sat_xprop opt_expr opt_expr_xprop
  - vsim_expr
make[1]: *** [run-test.mk:696: xprop_bwmux_3] Error 1

The mapping by bwmuxmap isn't x-prop faithful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write_verilog does not replace bwmux instances
1 participant