✨ Add Custom Net Device #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (explicitFilename) { | ||
| filename = prefix; | ||
| } else { | ||
| filename = pcapHelper.GetFilenameFromDevice(prefix, device); |
There was a problem hiding this comment.
Does this mean we can mess with the file names a bit? Might help to clear up the different suffixes to know which gateway we are looking at.
There was a problem hiding this comment.
This one is a little bit beyond me but I assume a lot is taken from NS3 source.
There was a problem hiding this comment.
most of it yeah, just modifying to create PointToPointFRRNetDevices instead
| { | ||
| NS_LOG_FUNCTION_NOARGS(); | ||
| switch (proto) { | ||
| case 0x0800: return 0x0021; // IPv4 |
There was a problem hiding this comment.
Seeing the protocol numbers that clearly in front of me is slightly infuriating.....
There was a problem hiding this comment.
yeah I was wondering where I got the number from 😂😂
charliebarber
approved these changes
Mar 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to address the issue with packets dropping when attempting to reroute. Also its marks the separation of the FRR Policy utilization by the Queue and instead it moves it up to the net device.