Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combined.cc implementing customNetDevice #13

Merged
merged 9 commits into from
Mar 16, 2024
Merged

combined.cc implementing customNetDevice #13

merged 9 commits into from
Mar 16, 2024

Conversation

charliebarber
Copy link
Collaborator

Getting this error:

FRRQueue:GetPointToPointDevice()
FRRQueue:GetDevice()
FRRQueue:GetPointToPointDevice()
FRRQueue:GetQueue(0xaaaac81c52d0)
NS_ASSERT failed, cond="m_ptr", msg="Attempted to dereference zero pointer", +0.000000000s -1 file=/usr/workspace/ns-allinone-3.41/ns-3.41/src/core/model/ptr.h, line=713
NS_FATAL, terminating
terminate called without an active exception
Command 'build/scratch/ns3.41-combined-default' died with <Signals.SIGABRT: 6>.

YousefEZ
YousefEZ reviewed Mar 15, 2024
View reviewed changes
src/combined.cc Outdated
Comment on lines 236 to 245
toggleCongestion(getQueue<0>(devices_0_2));
toggleCongestion(getQueue<1>(devices_0_2));
toggleCongestion(getQueue<0>(devices_2_4));
toggleCongestion(getQueue<1>(devices_2_4));
toggleCongestion(getQueue<0>(devices_4_3));
toggleCongestion(getQueue<1>(devices_4_3));
toggleCongestion(getQueue<0>(devices_3_5));
toggleCongestion(getQueue<1>(devices_3_5));
toggleCongestion(getQueue<0>(devices_1_2));
toggleCongestion(getQueue<1>(devices_1_2));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these devices are not using a simulation queue, and could trigger a segfault.

e.g. devices_0_2

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only devices_2_3 is has a simulation queue

@charliebarber
Copy link
Collaborator Author

Ready for review. Combined.cc now ready for experimental setup.

@charliebarber charliebarber marked this pull request as ready for review March 16, 2024 16:17
@charliebarber charliebarber requested a review from YousefEZ March 16, 2024 17:09
YousefEZ
YousefEZ approved these changes Mar 16, 2024
View reviewed changes
Copy link
Owner

@YousefEZ YousefEZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM well done!

@charliebarber charliebarber merged commit bc03d88 into main Mar 16, 2024
5 checks passed
@YousefEZ YousefEZ deleted the combined-customNetDevice branch April 12, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YousefEZ YousefEZ YousefEZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliebarber @YousefEZ