Eliminate COSE-Java dependency #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point this is the only thing we really use the COSE-Java library for. At the cost of this small bit of extra code we can eliminate the dependency, one benefit of which is that downstream security review gets easier.
Test Results1 241 tests 1 237 ✅ 55s ⏱️ For more details on these parsing errors, see this check. Results for commit ee3ecf3. |
dainnilsson
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #348.
At this point the only thing we really use the COSE-Java library for is importing ES256 keys. At the cost of a small bit of extra code we can eliminate the dependency, one benefit of which is that downstream security review gets easier.
The plan is to release this (and possibly a few other minor fixes) as release
2.5.1so we can get this out before committing to stabilize2.6.0, since2.6.0-alpha*add a lot of new API surface.