Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree-view horizontal scroll by removing extra overflow: hidden #19

Closed
wants to merge 1 commit into from

Conversation

paradoxxxzero
Copy link
Contributor

This fixes #3

@noudadrichem
Copy link
Collaborator

Hi @paradoxxxzero ,

Thank you for your PR, have you checked this out with git status and selected files?
When I tried this it starting to bug those 2.

Sincerely

@paradoxxxzero
Copy link
Contributor Author

You are right, it bugs on horizontal scroll.
I investigated a bit more and letting the tree-view-root min-width at min-content (Removing this line: https://github.com/Yummygum/city-lights-ui-atom/blob/master/styles/tree-view.less#L21) fixes the scroll but the git indicator is logically positioned at the right end of the panel and thus hidden by the scroll.

I have no idea how to have both the git indicator always visible at the right side and a horizontal scroll.
Sorry!

@noudadrichem
Copy link
Collaborator

This is the same issue I stumbled on, thank you for your help! I'll investigate this more!

@jedwards1211
Copy link

jedwards1211 commented Nov 12, 2018

@noudadrichem When I discovered this fix independently in the dev tools itself, it didn't push the status icons over beyond the right of the scroll pane. It causes the ugly layout issue pictured below but this is very preferable to not being able to scroll horizontally.
Have you considered moving the status icons to the left side of the tree view instead?
The right side would work fine if the icons could stick to the right side regardless of the horizontal scroll position, but it would be impossible to get this ideal behavior with pure CSS.
Icons on the right side of any tree view are just prone to layout issues:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File navigator window has no horizontal scroll
3 participants