Bookworm + Portal rework #1657

alexAubin · 2023-05-04T22:12:04Z

cf YunoHost/issues#2050

src/migrations/0027_migrate_to_bookworm.py

debian/changelog

src/user.py

src/dyndns.py

src/utils/form.py

src/authenticators/ldap_ynhuser.py

src/__init__.py

+    allowed_cors_origins_file = "/etc/yunohost/.admin-api-allowed-cors-origins"
+
+    if os.path.exists(allowed_cors_origins_file):
+        allowed_cors_origins = open(allowed_cors_origins_file).read().strip().split(",")


src/__init__.py

+    allowed_cors_origins_file = "/etc/yunohost/.portal-api-allowed-cors-origins"
+
+    if os.path.exists(allowed_cors_origins_file):
+        allowed_cors_origins = open(allowed_cors_origins_file).read().strip().split(",")


github-advanced-security

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

kay0u · 2023-11-29T16:57:28Z

hooks/conf_regen/15-nginx

-    export experimental="$(yunohost settings get 'security.experimental.security_experimental_enabled' | int_to_bool)"
+    export redirect_to_https="$(jq -r '.nginx_redirect_to_https' <<< "$YNH_SETTINGS" | int_to_bool)"
+    export compatibility="$(jq -r '.nginx_compatibility' <<< "$YNH_SETTINGS" | int_to_bool)"
+    export experimental="$(jq -r '.security_experimental_enabled' <<< "$YNH_SETTINGS" | int_to_bool)"


Is moving security.experimental.security_experimental_enabled to security.nginx.security_experimental_enabled intentional?

uuuh not sure what you mean ? The setting "long name" is still security.experimental.security_experimental_enabled but $YNH_SETTINGS contains only the short name for whatever reason

oh yeah, I misread the python code associated with the commit

src/utils/form.py

        if not option.is_visible(context):
            if isinstance(option, BaseInputOption):
                # FIXME There could be several use case if the question is not displayed:
                # - we doesn't want to give a specific value
                # - we want to keep the previous value
                # - we want the default value
-                option.value = context[option.id] = None
+                context[option.id] = None


src/utils/form.py

-                        option.choices if isinstance(option, BaseChoicesOption) else []
-                    )
+                # only update the context with the value
+                context[option.id] = option.normalize(form[option.id])


src/utils/form.py

+                option = next(opt for opt in options if option.id == option_id)
+                if option and isinstance(option, BaseInputOption):
+                    form[option.id] = option.normalize(value, option)
+                    context[option.id] = form[option.id]


src/utils/configpanel.py

+# ╰───────────────────────────────────────────────────────╯
+
+if TYPE_CHECKING:
+    FilterKey = Sequence[Union[str, None]]


src/utils/configpanel.py

+
+if TYPE_CHECKING:
+    FilterKey = Sequence[Union[str, None]]
+    RawConfig = OrderedDict[str, Any]


doc/generate_configpanel_and_formoptions_doc.py

+
+def print_config_panel_docs():
+    fname = "../src/utils/configpanel.py"
+    content = open(fname).read()


doc/generate_configpanel_and_formoptions_doc.py

+
+def print_form_doc():
+    fname = "../src/utils/form.py"
+    content = open(fname).read()


src/utils/form.py

src/authenticators/ldap_ynhuser.py

src/tests/test_permission.py

src/authenticators/ldap_admin.py

src/authenticators/ldap_ynhuser.py

src/tests/test_sso_and_portalapi.py

fix data returned by ldap being list, and rename user_fullname to fullname

#2445: Pass email, username and fullname as header for ssowat

…se it's already provided by /etc/nginx/fastcgi_params + make sure it is mapped to the YNH_USER from SSOwat rather than $remote_user

…ted mimetype

Enh portal tiling

github-advanced-security bot found potential problems May 5, 2023

View reviewed changes

src/migrations/0027_migrate_to_bookworm.py Fixed Show fixed Hide fixed

src/migrations/0027_migrate_to_bookworm.py Fixed Show fixed Hide fixed

src/migrations/0027_migrate_to_bookworm.py Fixed Show fixed Hide fixed

src/migrations/0027_migrate_to_bookworm.py Fixed Show fixed Hide fixed

alexAubin force-pushed the bookworm branch 2 times, most recently from cd1bb22 to bed9ecc Compare May 15, 2023 20:13

kay0u reviewed Jun 5, 2023

View reviewed changes

debian/changelog Outdated Show resolved Hide resolved

alexAubin force-pushed the bookworm branch from 7036c6e to 194eb9c Compare June 13, 2023 18:40

github-advanced-security bot found potential problems Jun 13, 2023

View reviewed changes

src/user.py Fixed Show fixed Hide fixed

alexAubin force-pushed the bookworm branch 4 times, most recently from 945ecdb to 8ac48ee Compare June 14, 2023 06:07

alexAubin added the 🏗️ Major project Big decision label Jul 10, 2023

github-advanced-security bot found potential problems Jul 11, 2023

View reviewed changes

alexAubin changed the title ~~Bookworm~~ Bookworm + Portal rework Sep 27, 2023

github-advanced-security bot found potential problems Sep 27, 2023

View reviewed changes

alexAubin marked this pull request as draft September 27, 2023 18:12

alexAubin force-pushed the bookworm branch 2 times, most recently from 5322f83 to fae3b67 Compare October 6, 2023 15:22

github-advanced-security bot found potential problems Oct 31, 2023

View reviewed changes

alexAubin force-pushed the bookworm branch from 7703ca2 to 587d729 Compare November 13, 2023 14:39

kay0u reviewed Nov 29, 2023

View reviewed changes

github-advanced-security bot found potential problems Dec 12, 2023

View reviewed changes

github-advanced-security bot found potential problems Dec 19, 2023

View reviewed changes

src/authenticators/ldap_admin.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Dec 21, 2023

View reviewed changes

src/authenticators/ldap_ynhuser.py Fixed Show fixed Hide fixed

src/authenticators/ldap_ynhuser.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Dec 27, 2023

View reviewed changes

alexAubin force-pushed the bookworm branch from cf62dff to e2aaf72 Compare January 14, 2024 16:36

alexAubin added 5 commits January 27, 2024 16:13

Cleanup legacy

dda095d

Moar lazy loading

8bd2104

Unused imports

6e85323

helpers: remove pre-4.2 behavior for default file/folders permissions

cc97efa

helpers: fix pattern to wait for when fail2ban is starting/reloading

d9daf11

Josue-T and others added 26 commits October 25, 2024 22:38

Avoid to pass the full headers keys in the cookie

415b5a6

fix confirmation during postinstall

7f117b0

Update domain.py: fix TOS confirmation during domain add with dyndns

6c435a5

Apply suggestions from code review

4e91742

fix data returned by ldap being list, and rename user_fullname to fullname

fstrings ftw

efabf32

cosmetics

3ae3423

Merge pull request #1981 from YunoHost/auth_headers

240e6a4

#2445: Pass email, username and fullname as header for ssowat

helpers/nginx: yoloremove the REMOTE_USER lines from app's conf becau…

cd36757

…se it's already provided by /etc/nginx/fastcgi_params + make sure it is mapped to the YNH_USER from SSOwat rather than $remote_user

configpanel: better error message when uploading a file from unsuppor…

d9f59f3

…ted mimetype

Annnd forgot the -i

0b336f1

portal: add multiple tiling themes

2a5fa9d

Merge pull request #1986 from YunoHost/enh-portal-tiling

197b3a5

Enh portal tiling

fix(portal): portal_tile_theme not optional

554bd6b

fix(domain): allow custom css removal

f64cc3f

i18n(portal): add portal_tile_theme translation key

0da8730

Merge remote-tracking branch 'origin/dev' into bookworm

aa27af6

Update changelog for 12.0.5

d709468

Merge remote-tracking branch 'origin/dev' into bookworm

7822abc

Update changelog for 12.0.5.1

09fe0b3

Merge remote-tracking branch 'origin/dev' into bookworm

593bd30

Update changelog for 12.0.5.2

1427c79

typo in generate-helpers-doc

ab7bbef

Merge branch 'dev' into bookworm

9d24a07

Update changelog for 12.0.5.3

debd916

Merge remote-tracking branch 'origin/dev' into bookworm

1f0a7ca

Update changelog for 12.0.6

94ad04b

Salamandar marked this pull request as ready for review October 31, 2024 17:17

Salamandar approved these changes Oct 31, 2024

View reviewed changes

alexAubin merged commit 85e904a into dev Oct 31, 2024
1 of 3 checks passed

alexAubin deleted the bookworm branch October 31, 2024 20:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bookworm + Portal rework #1657

Bookworm + Portal rework #1657

alexAubin commented May 4, 2023

github-advanced-security bot left a comment

kay0u Nov 29, 2023 •

edited

Loading

alexAubin Nov 29, 2023

kay0u Nov 29, 2023

Bookworm + Portal rework #1657

Bookworm + Portal rework #1657

Conversation

alexAubin commented May 4, 2023

github-advanced-security bot left a comment

Choose a reason for hiding this comment

kay0u Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

alexAubin Nov 29, 2023

Choose a reason for hiding this comment

kay0u Nov 29, 2023

Choose a reason for hiding this comment

kay0u Nov 29, 2023 •

edited

Loading