Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: Enhance app_shell() #1681

Merged
merged 2 commits into from
Jun 20, 2023
Merged

apps: Enhance app_shell() #1681

merged 2 commits into from
Jun 20, 2023

Conversation

tituspijean
Copy link
Contributor

@tituspijean tituspijean commented Jun 20, 2023 •
edited
Loading

  • Make sure spawning an app shell does not lock the YunoHost CLI
  • Offer to preload the php command with flags (from a phpflags app setting), useful for Nextcloud for example: its php${phpversion} --define apc.enable_cli=1 occ... would be simplified to php occ ... if phpflags="--define apc.enable_cli=1")

PR Status

Finished

How to test

Lock avoidance tested. PHP flags yolocommitted.

@alexAubin alexAubin changed the title Enhance app_shell() apps: Enhance app_shell() Jun 20, 2023
@alexAubin alexAubin merged commit bcd2550 into dev Jun 20, 2023
@alexAubin alexAubin deleted the enh_app_shell branch June 20, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tituspijean @alexAubin