fix(eslint-config): removed damn rules

Yurchishin · Sep 26, 2023 · aa97cf2 · aa97cf2
1 parent 99339eb
commit aa97cf2
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 21 deletions.
diff --git a/packages/eslint-config/src/shared/import-ts.cjs b/packages/eslint-config/src/shared/import-ts.cjs
@@ -1,3 +1,3 @@
 const { createImportConfig } = require('./import.cjs')
 
-module.exports = createImportConfig(false)
+module.exports = createImportConfig(true)
diff --git a/packages/eslint-config/src/shared/regexp.cjs b/packages/eslint-config/src/shared/regexp.cjs
@@ -8,4 +8,7 @@ module.exports = {
     sourceType: 'module',
   },
   extends: ['plugin:regexp/recommended'],
+  rules: {
+    'regexp/strict': 'off',
+  },
 }
diff --git a/packages/eslint-config/src/shared/typescript.cjs b/packages/eslint-config/src/shared/typescript.cjs
@@ -43,7 +43,7 @@ module.exports = {
         fixStyle: 'separate-type-imports',
       },
     ],
-    '@typescript-eslint/explicit-function-return-type': 'error',
+    '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/explicit-member-accessibility': 'off',
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/member-ordering': [
@@ -141,7 +141,7 @@ module.exports = {
             'protected-decorated-method',
           ],
           optionalityOrder: 'optional-first',
-          order: 'alphabetically-case-insensitive',
+          order: 'as-written',
         },
       },
     ],
@@ -150,18 +150,24 @@ module.exports = {
       'error',
       {
         selector: ['accessor', 'method', 'parameterProperty', 'property', 'function', 'parameter'],
-        format: ['camelCase'],
+        format: ['camelCase', 'PascalCase'],
         leadingUnderscore: 'allow',
         trailingUnderscore: 'forbid',
       },
       {
         selector: ['variable'],
-        format: ['camelCase', 'UPPER_CASE'],
+        format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
         leadingUnderscore: 'allow',
         trailingUnderscore: 'forbid',
       },
       {
-        selector: ['class', 'enum', 'enumMember', 'interface', 'typeAlias', 'typeParameter'],
+        selector: ['typeAlias'],
+        format: ['PascalCase'],
+        leadingUnderscore: 'allow',
+        trailingUnderscore: 'forbid',
+      },
+      {
+        selector: ['class', 'enum', 'enumMember', 'interface', 'typeParameter'],
         format: ['PascalCase'],
         leadingUnderscore: 'forbid',
         trailingUnderscore: 'forbid',
@@ -236,7 +242,7 @@ module.exports = {
     '@typescript-eslint/parameter-properties': [
       'error',
       {
-        prefer: 'parameter-property',
+        prefer: 'class-property',
       },
     ],
     '@typescript-eslint/prefer-as-const': 'error',
@@ -254,7 +260,7 @@ module.exports = {
     '@typescript-eslint/prefer-nullish-coalescing': 'error',
     '@typescript-eslint/prefer-optional-chain': 'error',
     '@typescript-eslint/prefer-readonly': 'error',
-    '@typescript-eslint/prefer-readonly-parameter-types': 'error',
+    '@typescript-eslint/prefer-readonly-parameter-types': 'off',
     '@typescript-eslint/prefer-reduce-type-parameter': 'error',
     '@typescript-eslint/prefer-regexp-exec': 'error',
     '@typescript-eslint/prefer-return-this-type': 'error',
@@ -288,17 +294,7 @@ module.exports = {
     '@typescript-eslint/strict-boolean-expressions': 'error',
     '@typescript-eslint/switch-exhaustiveness-check': 'error',
     '@typescript-eslint/triple-slash-reference': 'error',
-    '@typescript-eslint/typedef': [
-      'error',
-      {
-        arrayDestructuring: false,
-        arrowParameter: true,
-        memberVariableDeclaration: true,
-        objectDestructuring: false,
-        parameter: true,
-        propertyDeclaration: true,
-      },
-    ],
+    '@typescript-eslint/typedef': 'off',
     '@typescript-eslint/unbound-method': 'error',
     '@typescript-eslint/unified-signatures': 'error',
 

diff --git a/packages/eslint-config/src/shared/unicorn.cjs b/packages/eslint-config/src/shared/unicorn.cjs
@@ -101,7 +101,7 @@ module.exports = {
     'unicorn/prefer-node-protocol': 'error',
     'unicorn/prefer-number-properties': 'error',
     'unicorn/prefer-switch': ['error', { minimumCases: 5 }],
-    'unicorn/prevent-abbreviations': 'error',
+    'unicorn/prevent-abbreviations': 'off',
     'unicorn/relative-url-style': 'error',
     'unicorn/text-encoding-identifier-case': 'error',
 

diff --git a/packages/eslint-config/src/tests.cjs b/packages/eslint-config/src/tests.cjs
@@ -1 +1,7 @@
-module.exports = {}
+module.exports = {
+  rules: {
+    '@typescript-eslint/no-confusing-void-expression': 'off',
+    'id-length': 'off',
+    'unicorn/better-regexp': 'off',
+  },
+}