Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: leverage .env file #42

Merged
merged 3 commits into from
Feb 18, 2024
Merged

feat: leverage .env file #42

merged 3 commits into from
Feb 18, 2024

Conversation

corno-manso
Copy link
Contributor

  • prevent user from modifying docker-compose.yml
  • prevent user from building db url by itself, thanks to dotenv-expand

- prevent user from modifying docker-compose.yml
- prevent user from building db url by itself, thanks to dotenv-expand
@Yureien
Copy link
Owner

Yureien commented Feb 4, 2024

Thanks for the PR, looks good to me!

I just had a small nitpick: should we be exposing the DB port by default in the compose file?

@corno-manso
Copy link
Contributor Author

I've refactored code related to db port just so it is only ever exposed to other services and not the host. is that what you meant?

With that, if anyone were to remote connect to mongo: then they'd have to modify docker-compose.yml. Same for people running more than 1 instance of mongo at the same host.

It does add more security to it, indeed. It's less convenient, though.

I'd say exposing by default is better, since anyone self-hosting is supposed to have inbound firewall rules anyway.

@Yureien Yureien merged commit 9031db0 into Yureien:main Feb 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants